Skip to content

Conversation

@yariksheptykin
Copy link
Contributor

@yariksheptykin yariksheptykin commented Mar 29, 2022

Closes #302
This PR backports pimcore/skeleton@73f0b4d to pimcore's demo.

@yariksheptykin yariksheptykin force-pushed the test_project_creation_actions branch from 985650d to 193a214 Compare March 29, 2022 20:05
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022

CLA assistant check
All committers have signed the CLA.

@yariksheptykin yariksheptykin marked this pull request as ready for review March 29, 2022 20:10
@yariksheptykin
Copy link
Contributor Author

A test run of this action can be found in my fork under https://github.com/yariksheptykin/demo/actions/runs/2060852960

@dvesh3
Copy link
Contributor

dvesh3 commented Mar 30, 2022

@yariksheptykin thanks for your PR! 👍 could you please sign the CLA?

@jdreesen
Copy link
Contributor

@CLAassistant seems to be a bit confused. How can it be signed and not-signed with only one commit?

@yariksheptykin
Copy link
Contributor Author

@yariksheptykin thanks for your PR! +1 could you please sign the CLA?

I tried to sign CLA multiple times yesterday. The CLA page renders blank to me and I cannot proceed. I managed to do it once somehow, but apparently this introduced even more confusion. Not sure how to get it fixed.

@yariksheptykin
Copy link
Contributor Author

yariksheptykin commented Mar 30, 2022

@CLAassistant does not seem to be awake yet.

Bildschirmfoto von 2022-03-30 09-38-23

@dvesh3
Copy link
Contributor

dvesh3 commented Mar 30, 2022

Ohh wait. It looks good in the checks
image

The comment above is confusing as first it shows signed then not signed. I'll delete the wrong comment manually to avoid confusion.

@yariksheptykin
Copy link
Contributor Author

@CLAassistant seems to be a bit confused. How can it be signed and not-signed with only one commit?

It's a "Schrödingers CLA"

@pimcore pimcore deleted a comment from CLAassistant Mar 30, 2022
@fashxp
Copy link
Member

fashxp commented Mar 30, 2022

everything seems alright, found you in the list 👍.

@yariksheptykin
Copy link
Contributor Author

@dvesh3 while porting this action to demo I noticed a tiny bug. The composer project was created in php8.0 environment, whereas pimcore installation ran under php8.1 as defined in docker-compose.yml file.
This changeset already corrects the issue. For the skeleton there is a PR pimcore/skeleton#87

@dvesh3 dvesh3 modified the milestone: 10.1.13 Apr 5, 2022
@dvesh3 dvesh3 self-assigned this Apr 5, 2022
@dvesh3 dvesh3 merged commit 5a62f04 into pimcore:10.x Apr 5, 2022
@dvesh3
Copy link
Contributor

dvesh3 commented Apr 5, 2022

@yariksheptykin thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action for testing project creation

5 participants