From 5eed18024a83cd4e60b6bc1f76939c1a14665c64 Mon Sep 17 00:00:00 2001 From: Alex Zamponi <562324+alexz707@users.noreply.github.com> Date: Fri, 21 Feb 2025 12:26:27 +0100 Subject: [PATCH 1/2] Adding return types to symfony extension methods --- .../PimcoreElasticsearchClientExtension.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DependencyInjection/PimcoreElasticsearchClientExtension.php b/src/DependencyInjection/PimcoreElasticsearchClientExtension.php index f169a05..40b9111 100644 --- a/src/DependencyInjection/PimcoreElasticsearchClientExtension.php +++ b/src/DependencyInjection/PimcoreElasticsearchClientExtension.php @@ -32,7 +32,7 @@ class PimcoreElasticsearchClientExtension extends ConfigurableExtension implemen const PIMCORE_CLIENT_PREFIX = 'pimcore.elasticsearch.custom_client.'; - protected function loadInternal(array $mergedConfig, ContainerBuilder $container) + protected function loadInternal(array $mergedConfig, ContainerBuilder $container): void { $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../../config')); $loader->load('services.yaml'); @@ -55,7 +55,7 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container $container->addDefinitions($definitions); } - public function prepend(ContainerBuilder $container) + public function prepend(ContainerBuilder $container): void { $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../../config')); $loader->load('default_config.yaml'); From eec77aea6be8ab086f364700c5482bcaa7b59d54 Mon Sep 17 00:00:00 2001 From: Alex Zamponi <562324+alexz707@users.noreply.github.com> Date: Tue, 11 Mar 2025 16:54:43 +0100 Subject: [PATCH 2/2] Add return types --- src/DependencyInjection/Configuration.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index 9475d63..5c69dd1 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -20,7 +20,7 @@ class Configuration implements ConfigurationInterface { - public function getConfigTreeBuilder() + public function getConfigTreeBuilder(): TreeBuilder { $treeBuilder = new TreeBuilder('pimcore_elasticsearch_client');