Skip to content

Remove deprecations #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Remove deprecations #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eed180
Adding return types to symfony extension methods
alexz707 Feb 21, 2025
eec77ae
Add return types
alexz707 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

class Configuration implements ConfigurationInterface
{
public function getConfigTreeBuilder()
public function getConfigTreeBuilder(): TreeBuilder
{
$treeBuilder = new TreeBuilder('pimcore_elasticsearch_client');

Expand Down
4 changes: 2 additions & 2 deletions src/DependencyInjection/PimcoreElasticsearchClientExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class PimcoreElasticsearchClientExtension extends ConfigurableExtension implemen

const PIMCORE_CLIENT_PREFIX = 'pimcore.elasticsearch.custom_client.';

protected function loadInternal(array $mergedConfig, ContainerBuilder $container)
protected function loadInternal(array $mergedConfig, ContainerBuilder $container): void
{
$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../../config'));
$loader->load('services.yaml');
Expand All @@ -55,7 +55,7 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container
$container->addDefinitions($definitions);
}

public function prepend(ContainerBuilder $container)
public function prepend(ContainerBuilder $container): void
{
$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../../config'));
$loader->load('default_config.yaml');
Expand Down
Loading