From b9e0a0bc302626eb1f9215219b3e7ac95fc24ac2 Mon Sep 17 00:00:00 2001 From: Herbert Roth Date: Fri, 17 Oct 2025 09:23:54 +0000 Subject: [PATCH 1/3] refactor: replace direct query access with ParameterBagHelper for verbosity retrieval --- src/EventSubscriber/DebugSubscriber.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/EventSubscriber/DebugSubscriber.php b/src/EventSubscriber/DebugSubscriber.php index 912fdb54..9e8cc385 100644 --- a/src/EventSubscriber/DebugSubscriber.php +++ b/src/EventSubscriber/DebugSubscriber.php @@ -13,6 +13,7 @@ namespace Pimcore\Bundle\GenericDataIndexBundle\EventSubscriber; +use Pimcore\Helper\ParameterBagHelper; use Pimcore; use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Debug\SearchInformation; use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\DefaultSearch\DefaultSearchService; @@ -48,7 +49,7 @@ public function onKernelResponse(ResponseEvent $event): void if (!Pimcore::inDebugMode() || empty($event->getRequest()->query->get(self::DEBUG_SEARCH_PARAM))) { return; } - $verbosity = $event->getRequest()->query->getInt(self::DEBUG_SEARCH_PARAM); + $verbosity = ParameterBagHelper::getInt($event->getRequest()->query, self::DEBUG_SEARCH_PARAM); $event->setResponse(new JsonResponse($this->getNormalizedSearches($verbosity))); } From 526e167a24047dde285b75293461e51f4952abee Mon Sep 17 00:00:00 2001 From: herbertroth Date: Thu, 23 Oct 2025 12:59:51 +0000 Subject: [PATCH 2/3] Apply php-cs-fixer changes --- src/EventSubscriber/DebugSubscriber.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/EventSubscriber/DebugSubscriber.php b/src/EventSubscriber/DebugSubscriber.php index 9e8cc385..f90b5954 100644 --- a/src/EventSubscriber/DebugSubscriber.php +++ b/src/EventSubscriber/DebugSubscriber.php @@ -13,11 +13,11 @@ namespace Pimcore\Bundle\GenericDataIndexBundle\EventSubscriber; -use Pimcore\Helper\ParameterBagHelper; use Pimcore; use Pimcore\Bundle\GenericDataIndexBundle\Model\DefaultSearch\Debug\SearchInformation; use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\DefaultSearch\DefaultSearchService; use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\SearchIndexServiceInterface; +use Pimcore\Helper\ParameterBagHelper; use Symfony\Component\EventDispatcher\EventSubscriberInterface; use Symfony\Component\HttpFoundation\JsonResponse; use Symfony\Component\HttpKernel\Event\ResponseEvent; From ab9867400ab2f1e45d4eb0baa32d8c2f21022b96 Mon Sep 17 00:00:00 2001 From: Herbert Roth Date: Thu, 23 Oct 2025 12:59:53 +0000 Subject: [PATCH 3/3] fix: update pimcore/pimcore requirement to ^12.3 in composer.json --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 1e325452..2f104a11 100644 --- a/composer.json +++ b/composer.json @@ -19,7 +19,7 @@ "require": { "php": "~8.3.0 || ~8.4.0 ", "nesbot/carbon": "^3.8.4", - "pimcore/pimcore": "^12.0", + "pimcore/pimcore": "^12.3", "pimcore/static-resolver-bundle": "^3.0", "pimcore/opensearch-client": "^2.0", "pimcore/elasticsearch-client": "^2.0",