Skip to content

Commit 2fd4685

Browse files
committed
[Admin] Translations - properly escape key on roweditor
1 parent e109dfe commit 2fd4685

File tree

1 file changed

+5
-2
lines changed
  • bundles/AdminBundle/Resources/public/js/pimcore/settings

1 file changed

+5
-2
lines changed

Diff for: bundles/AdminBundle/Resources/public/js/pimcore/settings/translation.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,10 @@ pimcore.settings.translation.domain = Class.create({
247247
];
248248

249249
var typesColumns = [
250-
{text: t("key"), sortable: true, dataIndex: 'key', flex: 1, editable: false, filter: 'string'},
250+
{text: t("key"), sortable: true, dataIndex: 'key', flex: 1, editable: false, filter: 'string',
251+
editor: new Ext.form.DisplayField({
252+
htmlEncode: true
253+
})},
251254
{text: t("type"), sortable: true, dataIndex: 'type', width: 100, editor: new Ext.form.ComboBox({
252255
triggerAction: 'all',
253256
editable: false,
@@ -315,7 +318,7 @@ pimcore.settings.translation.domain = Class.create({
315318
icon: "/bundles/pimcoreadmin/img/flat-color-icons/delete.svg",
316319
handler: function (grid, rowIndex) {
317320
let data = grid.getStore().getAt(rowIndex);
318-
pimcore.helpers.deleteConfirm(t('translation'), data.data.key, function () {
321+
pimcore.helpers.deleteConfirm(t('translation'), Ext.util.Format.htmlEncode(data.data.key), function () {
319322
grid.getStore().removeAt(rowIndex);
320323
}.bind(this));
321324
}.bind(this)

0 commit comments

Comments
 (0)