From 8244ad3e175dfa4d4033abc672b4eded86222712 Mon Sep 17 00:00:00 2001 From: Paulo Vitor Bettini de Paiva Lima Date: Fri, 16 Nov 2018 15:42:59 +0100 Subject: [PATCH] fixed the isFieldDirty to avoid uninitialised keys it will avoid getting the warning bellow: Notice: Undefined index: o_parentId #0 /vendor/pimcore/pimcore/models/DataObject/Concrete/Dao.php(226): Pimcore\Model\DataObject\Colour->isFieldDirty('o_parentId') #1 /vendor/pimcore/pimcore/models/DataObject/Concrete.php(222): Pimcore\Model\DataObject\Concrete\Dao->update(true, Array) #3 /vendor/pimcore/pimcore/models/DataObject/AbstractObject.php(644): Interceptor\Main->update(true, Array) #4 /vendor/pimcore/pimcore/models/DataObject/Concrete.php(705): Pimcore\Model\DataObject\AbstractObject->save() --- models/DataObject/Traits/DirtyIndicatorTrait.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/DataObject/Traits/DirtyIndicatorTrait.php b/models/DataObject/Traits/DirtyIndicatorTrait.php index d5babeaf7cb..94e52360805 100644 --- a/models/DataObject/Traits/DirtyIndicatorTrait.php +++ b/models/DataObject/Traits/DirtyIndicatorTrait.php @@ -39,7 +39,7 @@ public function hasDirtyFields() */ public function isFieldDirty($key) { - if (is_array($this->o_dirtyFields) && $this->o_dirtyFields[$key]) { + if (is_array($this->o_dirtyFields) && array_key_exists($key, $this->o_dirtyFields)) { return true; }