Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep usagelog even after sended to Pimcore Team. #1128

Closed
Yivan opened this issue Dec 15, 2016 · 1 comment
Closed

Keep usagelog even after sended to Pimcore Team. #1128

Yivan opened this issue Dec 15, 2016 · 1 comment

Comments

@Yivan
Copy link
Contributor

Yivan commented Dec 15, 2016

Actually everytime the usagelog.log is sended to the Pimcore Team, the file is deleted.
The content of this file is great to retrieve which user make which action if needed.
I think it should be keeped zipped on the server and not being unlink like it is done actually. Please see:
https://github.com/pimcore/pimcore/blob/master/pimcore/lib/Pimcore/Log/Maintenance.php#L140

Actually on a project we wanted to consult this log and it was just flushed and deleted some hours ago... as we wanted to get yesterday information, we lost them : (
The only way to prevent this seems to desactivate the submission for now.

Thanks!

@Yivan
Copy link
Contributor Author

Yivan commented Jan 14, 2017

Sorry the line is 104, not 140:
https://github.com/pimcore/pimcore/blob/master/pimcore/lib/Pimcore/Log/Maintenance.php#L104

We can see here that the only way to keep usagelog is to disable usage sending (so return line 96 is executed) if we do not want to lost recent usage log (sending is based on the number of line, not on the time like the log cleaning on line 140).

A solution will be: change sending to time based criteria (30 days old for instance) wich involve file rotation (archive of this file). So at least we are sure at each time to be able to check usages 30 days back.
Another solution is simply not delete it (like if sending to pimcore checkbox was not cheked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants