New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset] Image Editor: increase size of image that get loaded into the editor #3723

Closed
Yivan opened this Issue Dec 7, 2018 · 2 comments

Comments

Projects
2 participants
@Yivan
Contributor

Yivan commented Dec 7, 2018

Hello,

As Pimcore admin logged in the Pimcore backend, using miniPaint image editor on an image asset, the opened image is not open with the good resolution.
Concequence is that if the image is save just after being opened in the image editor, the new image lost quality as resolution is splitted by a factor 2 it seems.
So if an enduser use the editor, he will degrade the resolution of the assets... : ( (pretty dangerous for system in production, actually the only way to prevent this is to disable temporarly the image editor).

Here is an opened image on the Pimcore demo:

image-editor

Here is the same image opened in the online demo of miniPaint:

image-editor-demo

So the problem seems to be on the Pimcore side i think.

Thanks.

@brusch brusch changed the title from [Bug] miniPaint degrade image resolution to [Asset] Image Editor: increase size of image that get loaded into the editor Dec 10, 2018

@brusch brusch closed this in 5cc5f7e Dec 10, 2018

@brusch

This comment has been minimized.

Member

brusch commented Dec 10, 2018

That's acutally no bug, it is necessary that Pimcore converts images to a smaller size and to a format miniPaint can read. It used to be 1000x1000 pixels at maximum, I've increased it now to 3000x3000 which seems to work on an average PC.

@brusch brusch added this to the 5.6.0 milestone Dec 10, 2018

@brusch brusch added this to To do in 26/11/2018 - 08/12/2018 via automation Dec 10, 2018

@brusch brusch added the Improvement label Dec 10, 2018

@brusch brusch self-assigned this Dec 10, 2018

@brusch brusch moved this from To do to Done in 26/11/2018 - 08/12/2018 Dec 10, 2018

@Yivan

This comment has been minimized.

Contributor

Yivan commented Dec 10, 2018

@brusch Thanks for your explaination and fix.

I understand this is a miniPaint limitation. Can i suggest the folowing:

  • if image is too big to display a message saying "Be carreful: picture was too big and has been reduced to XXX x YYY pixels". Because if user just open the image, make a small modification and save it, he can miss the fact that resolution of the image asset has been reduced.
    I really think it would be safer to inform the user via such an alert message, so he doesn't degrate asset resolution unintentionnaly.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment