New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimcore 5.6.0 Update - Migration 20181126094412 failed when PimcoreEcommerceFrameworkBundle not enabled #3806

Open
davidhoeck opened this Issue Jan 6, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@davidhoeck
Copy link
Contributor

davidhoeck commented Jan 6, 2019

Expected behavior

Successful execution of migration after the update

Actual behavior

You have requested a non-existent service "pimcore_ecommerce.factory". because EcommerceBundle not enabled in the container. If it is enabled, the migration works fine.

@davidhoeck davidhoeck changed the title Pimcore 5.6.0 Update - Migration 20181126094412 failed when EcommerceBundle not registered Pimcore 5.6.0 Update - Migration 20181126094412 failed when PimcoreEcommerceFrameworkBundle not enabled Jan 6, 2019

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor

dpfaffenbauer commented Jan 7, 2019

thats interesting: https://github.com/pimcore/pimcore/blob/master/bundles/CoreBundle/Resources/migrations/Version20181126094412.php#L23

the migration doesn't have anything todo with the ecommerce framework.

@brusch

This comment has been minimized.

Copy link
Member

brusch commented Jan 7, 2019

Very interesting ... I'm even not able to reproduce it ... just tried it twice with the basic demo.

@davidhoeck

This comment has been minimized.

Copy link
Contributor

davidhoeck commented Jan 7, 2019

It is extremely weird - I also tried to reproduce it in a new installation with the same setup, but I am not able to.
I just wanted to post it as an issue - maybe somebody else will experience this problem also!

@brusch

This comment has been minimized.

Copy link
Member

brusch commented Jan 7, 2019

Ok, I'm leaving this issue open for now, let's see if someone else stumbles upon this.

@ITspirit

This comment has been minimized.

Copy link

ITspirit commented Jan 15, 2019

Now have the same issue on migration. E-Commerce Framework is not installed (but was some times ago - till i've choosen to use coreshop and disabled/uninstall e-commerce framework).
After re-install the migration works (and just afterwards i unistalled e-commerce fw again).

Maybe there remain some pieces still after uninstall of the ecommerce-framework or reside within the VCS (classes/definiton_* for example).

UPDATE: after further debugging it seems to be in correlation with files (left from e-commerce-framework after uninstall). if you delete these files (in var/classes) manually - migration works

field collection "OrderPriceModifications"
field collection "FilterMultiSelect"
field collection "PaymentInfo"
field collection "PricingRule"
field collection "VoucherTokenTypePattern"
field collection "FilterMultiSelectFromMultiSelect"
field collection "VoucherTokenTypeSingle"
field collection "FilterNumberRangeSelection"
field collection "FilterNumberRange"
field collection "FilterRelation"
field collection "FilterSelect"
field collection "OrderByFields"
field collection "FilterCategory"
field collection "TaxEntry"
field collection "SimilarityField"
field collection "FilterInputfield"
field collection "FilterSelectFromMultiSelect"
field collection "FilterMultiRelation"
field collection "FilterCategoryMultiselect"

class "FilterDefinition"
class "OfferToolCustomProduct"
class "OfferToolOffer"
class "OfferToolOfferItem"
class "OnlineShopOrder"
class "OnlineShopOrderItem"
class "OnlineShopTaxClass"
class "OnlineShopVoucherSeries"
class "OnlineShopVoucherToken"

object brick "PaymentProviderQpay"
object brick "PaymentProviderMpay24"
object brick "PaymentProviderDatatrans"
object brick "PaymentProviderWirecardSeamless"
object brick "PaymentProviderOGone"
object brick "PaymentProviderPayPal"

Normally i would expect that a bundle removes files created if it's uninstalled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment