Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Objects] Null Values for Checkbox Data-Type #4305

Open
brusch opened this issue Apr 30, 2019 · 1 comment

Comments

@brusch
Copy link
Member

commented Apr 30, 2019

Currently it's not possible to set a checkbox back to null.
This has several impacts:

  • when using interitance, it's not possible to reset the status of a checkbox to get the parents value
  • isEmpty() returns currently true even if the value is set to false
  • problems in combination with the "default value" setting in the data-type config, the default value get's assigned in the UI when the value is null -> this causes issue when used in combination with inheritance (if object has no parent of the same type, null is returned (see also attached screenshot).

Todo:

  • introduce NULL state (we need a button next to the checkbox in the UI - only when inheritance is enabled, no benefits if object doesn't support inheritance).
  • change isEmpty() to only check for NULL
@brusch

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

foo

@weisswurstkanone weisswurstkanone added this to To do in Pimcore 6.0.0 ("Ale") via automation May 8, 2019

weisswurstkanone added a commit that referenced this issue May 8, 2019

@weisswurstkanone weisswurstkanone added this to the 5.8.2 milestone May 8, 2019

@weisswurstkanone weisswurstkanone moved this from To do to In progress in Pimcore 6.0.0 ("Ale") May 8, 2019

@weisswurstkanone weisswurstkanone referenced a pull request that will close this issue May 8, 2019

Open

Checkbox nullvalue #4338

@brusch brusch modified the milestones: 5.8.2, 5.9.0, 5.8.3, 6.0.0 May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.