Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Handling for Bricks #4353

Open
dpfaffenbauer opened this issue May 13, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@dpfaffenbauer
Copy link
Contributor

commented May 13, 2019

Since Bricks are actually nothing else than a Symfony Sub Request, shouldn't symfony be able to handle exceptions for them? For example: I am currently building a Security Area where all of the backend pages are build within Pimcore. I have to check for authorization and would just throw a AccessDeniedException, but that doesn't work cause Pimcore handles any throwable directly in the Document\Tag.

https://github.com/pimcore/pimcore/blob/master/models/Document/Tag.php#L475

What do you guys think about changing that behaviour for Bricks? For BC reasons, we could add a property/method to keep the behaviour as it is right now but have the possibility to throw exceptions and let them handle from symfony?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.