Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce] Add possibility to define expiry date for voucher tokens #4374

Open
fashxp opened this issue May 15, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@fashxp
Copy link
Member

commented May 15, 2019

on voucher token level

@fashxp fashxp added the Improvement label May 15, 2019

@NiklasBr

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Isn't this already implemented as a price rule condition? I.e. you always add the voucher to a price rule as a condition anyway so the logical place would be to also keep the date range condition in the same interface. No?

@fashxp

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

it is.
but there may be use cases where a voucher-code is valid e.g. 1 year from voucher-code handout. and voucher-codes are handed out on different dates ... so one would have to create a separate pricing rule for each voucher-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.