Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles/Users: allowed types to create is limited by varchar(255) column #4495

Open
macghriogair opened this issue Jun 6, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@macghriogair
Copy link

commented Jun 6, 2019

Bug Report

Pimcore 5.6.6
MariaDB 10.1.14

  • This is not a security issue / vulnerability -> use this form instead
  • Behavior is reproducible on http://demo-basic.pimcore.org/admin/ (admin/demo)
  • You're not able to fix the problem yourself and send us a pull request instead of an issue.
  • There's no existing ticket for the same issue

Expected behavior

It should be possible to store a reasonable amount of classes a User/Role is allowed to create and use custom unique class identifiers.

Actual behavior

Our classes use speaking unique identifiers, i.e. AcmeProductCompositionItem.
We cannot configure roles with more than x allowed classes because the users.classes column currently is limited to varchar(255). With numeric class ids this might not have been critical, but since Pimcore allows for unique class identifiers contain up to 64 characters this breaks permission management.

Steps to reproduce

  • Have about 10 classes with rather long unique identifiers
  • Create a new Role
  • Select 10 classes in "Allowed types to create"
  • Save & refresh role tab
  • Not all previously selected classes are selected

Check also users table for the created role: The classes column contains truncated list of class identifiers.

Bildschirmfoto 2019-06-06 um 15 31 55

macghriogair added a commit to macghriogair/pimcore that referenced this issue Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.