Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Allow debug without using debug email. #4500

Open
Yivan opened this issue Jun 7, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Yivan
Copy link
Contributor

commented Jun 7, 2019

Hello,

For some maintenance work, sometimes it is needed to activate debug mode in production.
Activating it, make all email to be send to the debug email...
This is really a problem as sometimes we just want rapidly activate it to see an error message, but in the meantime email will no more be routed to the true final user.
I know we could read the log and don't activate debug, but some tasks could need it.
This is a real problem we have struggled sometimes.

Suggestion:
Create a new debug_email option, so we can activate the debug or debug_email options separatly.
Or if we want to keep that by default, activating debug redirect the email to, the option name could be a checkbox "don't send email to debug email in debug mode".

Thanks.

@aarongerig

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Hi @Yivan,

Correct me if I’m wrong, but as far as I know, you can specify the debug mode to be active for only a certain IP address. For all other users with a different IP address the debug mode won‘t take effect, same goes for sending emails of course.

@Yivan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@aarongerig Yes you are true, this is a way to limit this problem.

The problem/danger is behind a reverse proxy.
What is dangerous I mean, is if trusted proxies are not set in the symfony config (or app.php), $_SERVER['HTTP_X_FORWARDED_FOR'] nor $_SERVER['HTTP_X_REAL_IP'] are not used, and just the $_SERVER['REMOTE_ADDR'] is used to prefill IP in the GUI and to make the PHP check too.
In this case, Pimcore prefill IP in the GUI with the one of the reverse proxy (so all request are considered in debug mode), making all emails be sended on the debug email : (

I know developper should configure the trusted proxies (see https://symfony.com/doc/current/deployment/proxies.html), but if it is not done, debug mode is clicked... all emails are sent to the debug address...
Having a separate settings will allow to be sure not even one email is lost in any case.

We have been experienced this, so that is why i suggest this improvement, to prevent more easily this.

At least if you think this should not be a separate settings, those things can be done:

Those are some ideas, to discuss, but i really think some improvement can be done at this level.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.