Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tooltips element inheritance #4502

Open
Pierre-Datasolution opened this issue Jun 10, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Pierre-Datasolution
Copy link

commented Jun 10, 2019

Hi Pimocre Team,

Bug Report

While using Custom Tooltips example [https://pimcore.com/docs/5.x/Development_Documentation/Objects/Object_Classes/Class_Settings/Custom_Icons.html], I saw that variant objects don't heritate parent values for inheritated fields

Expected behavior

Variant object should heritate parent value

Actual behavior

Inheritated fileds are empty/null

Steps to reproduce

Create a class with variants and at least one input inherited field (in my case, for class ModeleVoiture, constructeur, ManyToOne relation, and descriptionCommerciale, input text, can be inherited from parent object)
Create a variant leaving this input field empty (inherited)
Override getElementQtipConfig() method and dump inherited value of object (in my case, getConstructeur() and getDenominationCommerciale() are empty as parent values are correct)

Code example

namespace AppBundle\Admin;

use AppBundle\Model\DataObject\ModeleVoiture;

class AdminStyle extends \Pimcore\Model\Element\AdminStyle {

    public function __construct($element) {
        parent::__construct($element);
    }

    public function getElementQtipConfig()
    {
        if ($this->element instanceof ModeleVoiture) {
            //$thumbnail = $this->element->getImage()->getThumbnail("exampleResize");
            return [
                "title" => (($this->element->getConstructeur())?$this->element->getConstructeur()->getNom():"Unknown")." - ".$this->element->getDenominationCommerciale(),
                "text" => $this->element->getDescriptionCommerciale()?$this->element->getDescriptionCommerciale():"No description"
            ];
        }
        return parent::getElementQtipConfig();
    }

}

Feature Request

Get proper inherited value for variant object

Thanks for your help
Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.