Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Structured Table keys inconsistent #4598
Consistent naming of row and column keys
Keys start with the number "1" and then get the key "name". Is this expected behaviour? I don't know because the documentation does not mention what I should expect and there are no comments in the code either which could help...
Steps to reproduce
I don’t think that is a good solution @brusch
I would much rather have the automatic naming be consistent, not mixed like it is today: “1, name, name, …’
My preference to solve this:
When that’s is done, also adding focus to the field would probably be a nice improvement.
IMO, it should be consistent as other data types. so adding option to "Select" data type adds an empty row with focus. Also, I don't see a point here to keep dummy values as most of the time you end up replacing them. @NiklasBr do you have a use-case for automatic naming?
@dvesh3 I pretty much agree. And your improvement idea seems good.
Personally I think using the as similar logic as possible to #4243 would make a lot of sense, both by possibly reusing code and making the user experience consistent.
While we are discussing improvements, renaming the UI columns to "Display name" and "Value" would be clearer than "Key" and "Label" (like for Select options).
I don't have a "perfect" use-case for automatic naming, other than to make it generally consistent and predictable. I personally would have settled for numeric values (1, 2, 3, ...) when I needed to create a Structured Table recently because I only had a need for the value to be human-readable and did not need to specify the machine-readable part, having it created automatically would have been nice.