Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce ElasticSearch] are fieldnames correctly excluded in loadGroupByValues? #4648

Open
fashxp opened this issue Jul 9, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@fashxp
Copy link
Member

commented Jul 9, 2019

check these and the following lines

vs. this snippet:

            //exclude all attributes that are already filtered
            $shortFieldname = $this->getTenantConfig()->getReverseMappedFieldName($fieldname);

            $excludedFieldnames = $filteredFieldnames;
            if(!array_key_exists($fieldname, $toExcludeFieldnames)) {
                $excludedFieldnames = array_merge($filteredFieldnames, [$shortFieldname => $shortFieldname]);
            }

            $specificFilters = [];
            //user specific filters
            $specificFilters = $this->buildFilterConditions($specificFilters, $excludedFieldnames);
            //relation conditions
            $specificFilters = $this->buildRelationConditions($specificFilters, $excludedFieldnames);

@fashxp fashxp added the Task label Jul 9, 2019

@fashxp

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

might be a topic when multi-select filters produce are AND and not OR conditions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.