Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pimcore6] Fix TODOs #4660

Open
dvesh3 opened this issue Jul 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dvesh3
Copy link
Contributor

commented Jul 10, 2019

Cleanup Pimcore 6 TODOs

* TODO Pimcore 6 set as constructor dependency

* TODO Pimcore 6 set as constructor dependency

// TODO Pimcore 6 rely on responseStack being set as constructor dependency

* TODO Pimcore 6 set event dispatcher as constructor parameter

* TODO Pimcore 6 set logger as constructor dependency

* TODO Pimcore 6 set event dispatcher as constructor parameter

* TODO Pimcore 6 add to constructor signature.

// TODO Pimcore 6 remove as soon as attribute factory was added to the constructor.

// TODO Pimcore 6 remove as soon as attribute factory was added to the constructor.

* TODO Pimcore 6 set modelFactory as constructor dependency

* TODO Pimcore 6 remove this setter and set as constructor dependency!

->append($this->buildOptionsNode('mapping')) // TODO Symfony 3.4 set as deprecated. TODO Pimcore 6 remove option completely.

// @TODO: BC layer, to be removed in v6.0

// @TODO: Remove in 6.0

// @TODO: ignoredAliases are there for BC reasons, to be removed in v6

some classes in path pimcore/bundles/AdminBundle/Resources/public/js/pimcore/object/tags/ e.g.

some classes in path pimcore/bundles/AdminBundle/Resources/public/js/pimcore/object/classes/data/ e.g.

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

I also found some in the JS files, maybe you can check them as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.