Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty minified_javascript_core JS returns status code 200 instead of 404 #4686

Closed
sknuell opened this issue Jul 12, 2019 · 0 comments

Comments

Projects
2 participants
@sknuell
Copy link
Contributor

commented Jul 12, 2019

Expected behavior

When the main minified JS for the CMS UI cannot be loaded via the script proxy a meaningful HTTP status code (e.g. 404) is returned and an error is logged.

/admin/misc/script-proxy?scripts=minified_javascript_core_{hash}.js&_dc={hash}

Actual behavior

When the main minified JS for the CMS UI cannot be loaded via the script proxy a 200 HTTP status code is returned with the file being empty. That leads to a broken UI after login and the reason for this is quite hard to debug, because of the 200 status code and only shows in form of follow up errors in the browser console

Steps to reproduce

  • Make minified_javascript_core_{hash}.js e.g. not readable by web server
  • login in and see that UI is not loaded with errors showing in the browser console

Btw, are there any plans to get rid off the script proxy and the lazy generation of the core JS?

@brusch brusch changed the title [Pimcore 5] Empty minified_javascript_core JS returns status code 200 Empty minified_javascript_core JS returns status code 200 Jul 15, 2019

@brusch brusch self-assigned this Jul 15, 2019

@brusch brusch added the Bug label Jul 15, 2019

@brusch brusch added this to To do in 04/07/2019 - 16/07/2019 via automation Jul 15, 2019

@brusch brusch added this to the 6.0.3 ("American Pale Ale") milestone Jul 15, 2019

@brusch brusch changed the title Empty minified_javascript_core JS returns status code 200 Empty minified_javascript_core JS returns status code 200 instead of 404 Jul 15, 2019

@brusch brusch closed this in 9b52fc6 Jul 15, 2019

04/07/2019 - 16/07/2019 automation moved this from To do to Done Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.