Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish language not available in admin translations #4775

Closed
tobiashelmer opened this issue Jul 26, 2019 · 3 comments

Comments

@tobiashelmer
Copy link

commented Jul 26, 2019

Bug Report

Expected behavior
Adding the Finnish language in your localization should allow to add admin translations for it as it's a common language

Actual behavior
If you add Finnish as a language you can't add translations for it in the admin translations as there is only an option for "Swedish (Finnland)" (shared translations got Finnland as an option. So you can set the document language to Finnish but can't add translations for it.

Steps to reproduce

  1. Try to add Finnish language in the Localization option - shorthand is "fi" (correct)
    localization_finnish

  2. Swedish Finnish as comparsion - shorthand is "sv_fi"
    localization_swedish_finnish

  3. Admin Translation don't show "Finnish" as language, only "Swedish (Finnland)"
    pimcore_admin_translations

  4. Now take a look at the "translations_admin" table in the database and see that the translations are saved under the language "sv_FI" but the locale you get from the documents is "fi" -> no translations are available. I fixed it by manually changing the language in the database from "sv_FI" to "fi"

@tobiashelmer tobiashelmer changed the title Finnish language not available in database Finnish language not available in admin translations Jul 26, 2019

@brusch brusch self-assigned this Jul 30, 2019

@brusch brusch added the Bug label Jul 30, 2019

@brusch brusch added this to the 6.1.0 ("Red Ale") milestone Jul 30, 2019

@brusch

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Works for me as it should, just tested on the public demo:

image

image

@brusch brusch closed this Jul 30, 2019

@tobiashelmer

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

And what about the admin translations? There is only a fixed set of languages disconnected from the languages inside the localization in the system settings. The shared translations are working fine with the selected languages

@brusch

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Admin translations are only available in the languages where there's a translation of the admin UI.
It won't make sense to allow Finnish admin translation if the entire UI isn't available in this language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.