Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Objects] Improve Variant functionalities in object tree #4793

Open
RuudvdvNB opened this issue Jul 31, 2019 · 2 comments

Comments

@RuudvdvNB
Copy link
Contributor

commented Jul 31, 2019

Feature Request

For variants it's not possible to duplicate or move variants inside the tree structure. The docs are stating that variants are exactly the same as objects and offer the same functions, but it turns out not everything is working exactly the same.

To make things easier for customers we would like to add variants automaticly in the second level of the variant tree. But the customer should be able to move the variant further down the tree.

@brusch brusch changed the title Variant functions inside object tree [Data Objects] Improve Variant functionalities inside object tree Aug 12, 2019

@brusch brusch changed the title [Data Objects] Improve Variant functionalities inside object tree [Data Objects] Improve Variant functionalities in object tree Aug 12, 2019

@pspierce

This comment has been minimized.

Copy link

commented Aug 16, 2019

Is this not a matter of DataObject\AbstractObject::OBJECT_TYPE_VARIANT being missing in a few places? I had to write a command-line script and feed it IDs and a new parent because I was being asked to move variants so often. Changing the parent ID doesn't appear to impact anything outside of inheritance, which is appropriate.

@brusch

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

@pspierce unfortunately not, @RuudvdvNB is talking about topics like that:

if(node.data.type == 'variant' && oldParent.data.id != newParent.data.id){

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.