Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data objects] Grid batch actions dosen't work without publish permission #4868

Open
prugala opened this issue Aug 20, 2019 · 0 comments

Comments

@prugala
Copy link
Contributor

commented Aug 20, 2019

Bug Report

Expected behavior

User without publish permission on objects can use batch actions

Actual behavior

User without permission can't edit objects. Exception Permission denied. You don't have the rights to save this object. is thrown.

Steps to reproduce

  1. Create a user without publish permission for objects (workspaces)
  2. Add object
  3. Try to use batch action on grid

Problem is here: https://github.com/pimcore/pimcore/blob/master/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php#L2152

I think we should throw an exception only if a user wants to edit publish value without permission.

We can move if statement to line 2167 and change it on:
if ($name === 'publish' && !$object->isAllowed('publish')) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.