Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Views] Errors are thrown if user logs in with insufficient rights #4881

Open
cmaerz opened this issue Aug 22, 2019 · 7 comments

Comments

@cmaerz
Copy link

commented Aug 22, 2019

Bug Report

I got about 10 custom views in a project. Since a recent update users that do not have the rights to view a custom view get an error popup.

Expected behavior

No Error Popup.

Actual behavior

One Error Popup for each custom view with no rights.

@dvesh3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Cannot Reproduce!!....could you please try to reproduce it on demo? https://demo-basic.pimcore.org/admin

@cmaerz

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Pretty sure it's not possible to reproduce on Demo as I can't edit the var/config/customviews.php file.

@dvesh3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

you are right! It would be great if you can share steps to reproduce it.

@cmaerz

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

I narrowed it down to this commits:
6d3b819
8fd4bc3

I don't have that problems on 6.1.1 but when it update to 6.1.2 the errors come up.

I got a few customviews like this:


return [
    "views" => [
        [
            "name" => "Neuigkeiten",
            "condition" => "",
            "icon" => "/bundles/pimcoreadmin/img/flat-white-icons/news.svg",
            "id" => "1",
            "rootfolder" => "/neuigkeiten",
            "showroot" => "1",
            "classes" => "1"
        ],
        [
            "name" => "Bekanntmachungen",
            "condition" => "",
            "icon" => "/bundles/pimcoreadmin/img/flat-white-icons/globe.svg",
            "id" => "20",
            "rootfolder" => "/bekanntmachungen",
            "showroot" => "1",
            "classes" => "18"
        ]
]
?>

But if a user doesn't have access to /neuigkeiten or /bekanntmachungen a error popup gots thrown that he has no access. Even it shouldn't matter to him.

@dvesh3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Sorry, works for me. let's wait for others to report it :)

@cmaerz

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

What Version you are on? I guess I only tested it on 6.1.2 - Will test on the newest one too

@dvesh3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Yes, please try on latest version. I'm on dev-master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.