Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data objects: Inconsistent prevention of unpublish #4943

Open
NiklasBr opened this issue Sep 5, 2019 · 0 comments

Comments

@NiklasBr
Copy link
Contributor

commented Sep 5, 2019

Bug Report

Expected behavior

This should above all be consistent. It would also be an improvement if there was documentation (inline or online) on why.

When a data object is locked, it should not be possible to publish and unpublish it anywhere.

or

When a data object is locked, it should be possible to publish and unpublish it anywhere.

Actual behavior

When a Data Object's parent is locked, then this code prevents users from unpublishing

            if (this.isAllowed("unpublish") && !this.data.general.o_locked) {
                buttons.push(this.toolbarButtons.unpublish);
            }

But only when editing the object directly. It is still possible to unpublish the object in the Grid view.

Steps to reproduce

  1. Lock an objects parent, propagate.
  2. Edit the object
  3. Publish/unpublish it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.