Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price System - Mockup ->getOSPrice() doesn't return correct price #4957

Open
ckogler-elements opened this issue Sep 9, 2019 · 0 comments

Comments

@ckogler-elements
Copy link
Contributor

commented Sep 9, 2019

If you call getOSPrice() on a Mockup the correct Price won't be returned because a check for "method_exists" won't fulfill the condition (unless you implement the method in your Mockup object).

https://github.com/pimcore/pimcore/blob/master/bundles/EcommerceFrameworkBundle/PriceSystem/AttributePriceSystem.php

-> line 126
use
if (is_callable([$product,$getter])) {
instead of
method_exists($product, $getter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.