Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Preview doesn't work with relations #5106

Open
dpfaffenbauer opened this issue Oct 17, 2019 · 4 comments

Comments

@dpfaffenbauer
Copy link
Contributor

@dpfaffenbauer dpfaffenbauer commented Oct 17, 2019

I debugged the issue, the problem are lazy loaded fields, since they don't get serialized without _fulldump. Also, when you add _fulldump for the session serialization, it get's removed later, cause \Pimcore\Tool\Session opens and closes the session like a million times per request... which unserializes it, removes the _fulldump and serializes it again.

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor Author

@dpfaffenbauer dpfaffenbauer commented Oct 17, 2019

Solutions might be:

  1. Change how Pimcore manages the Session by not opening or closing it like a million times.
  2. Serialize the Session Object into the TmpStore with an identifier saved into the session. So the Object doesn't get unserialized and serialized like a million times.
  3. Remove the unset($this->_fulldump) on __wakeup in AbstractObject, but that for sure has sideeffects for Versions.
  4. Introduce proper serialization und unserialization for Pimcore DataObjects.

The quick fix would be Solution 2.

@brusch

This comment has been minimized.

Copy link
Member

@brusch brusch commented Oct 24, 2019

@dpfaffenbauer I've done some optimizations on the admin sessions, would be nice if you could review them, see #5145

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor Author

@dpfaffenbauer dpfaffenbauer commented Oct 24, 2019

@brusch will test your PR later. Hopefully tomorrow.

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor Author

@dpfaffenbauer dpfaffenbauer commented Oct 29, 2019

Just tested, doesn't work for me....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.