Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ckeditor-plugin "clipboard" (see #3831) breaks advanced content filter #5151

Open
thgross opened this issue Oct 25, 2019 · 0 comments

Comments

@thgross
Copy link
Contributor

@thgross thgross commented Oct 25, 2019

In #3831, ckeditor's "clipboard"-plugin was removed. There is no need to remove the plugin just because the paste-buttons don't work anymore in modern browsers.
The main problem with this is that ckeditor needs the "clipboard"-plugin to trigger it's advanced content filter (acf). This is why even the most basic preset for any ckeditor configuration has this plugin enabled.

The "clipboard"-plugin needs to be re-added to ckeditor.

Edit: to clarify - the acf still works, because on reopening a document with a wysiwyg that contains unallowed styles, the content gets properly filtered.
However, if you just paste content to the wysiwyg and then save, the content is NOT being filtered (but it should).

Expected behavior

Pasting any formatted text into an wysiwyg-editor triggers ckeditors acf. Tihs filter ist enabled by default and removes any unwanted formatting, ie. styles.

Actual behavior

Pasting formatted text keeps any unwanted styles.

Steps to reproduce

  1. Copy the colorful line of text from https://ckeditor.com/docs/ckeditor4/latest/examples/acf.html in any wysiwyg-editor in pimcore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.