Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image thumbnails disappears from asset listing #5306

Closed
neha04 opened this issue Nov 21, 2019 · 10 comments
Assignees
Labels
Bug

Comments

@neha04
Copy link
Contributor

@neha04 neha04 commented Nov 21, 2019

Expected behavior

The image thumbnails must not disappear from asset preview listing(Preview Tab)

Actual behavior

Image thumbnails disappears from asset listing if we hover again on the assets in the asset tree

Steps to reproduce

  • Open asset folder.
  • Now expand that folder in tree and quickly hover some of the assets.
  • Those assets disappears from the asset listing.

asset

asset-list-2

@dvesh3

This comment has been minimized.

Copy link
Contributor

@dvesh3 dvesh3 commented Nov 21, 2019

cannot reproduce!..do you see any error on console?

@neha04

This comment has been minimized.

Copy link
Contributor Author

@neha04 neha04 commented Nov 22, 2019

No,There was no error in console.You may also try opening a folder.Then open a few images from the tree(open those that are visible in the preview list).Now open folder using tab panel.

@neha04

This comment has been minimized.

Copy link
Contributor Author

@neha04 neha04 commented Nov 22, 2019

@thgross

This comment has been minimized.

Copy link
Contributor

@thgross thgross commented Nov 22, 2019

This happens to me, too. Only in Chrome.

@dvesh3

This comment has been minimized.

Copy link
Contributor

@dvesh3 dvesh3 commented Nov 22, 2019

@neha04 @thgross Please share Chrome version.

@thgross

This comment has been minimized.

Copy link
Contributor

@thgross thgross commented Nov 22, 2019

My current Chrome Version is 78.0.3904.108. It happened for at least 3 major Chrome releases, so this problem is not bound to a specific version of Chrome.

@neha04

This comment has been minimized.

Copy link
Contributor Author

@neha04 neha04 commented Nov 25, 2019

My current Chrome Version is Version 74.0.3729.169 (Official Build) (64-bit)

@dvesh3 dvesh3 added the Bug label Nov 25, 2019
@dvesh3 dvesh3 self-assigned this Nov 25, 2019
@AlternateIf

This comment has been minimized.

Copy link
Contributor

@AlternateIf AlternateIf commented Dec 4, 2019

can also reproduce this on the pimcore demo. oddly this is only reproducible if the chrome console is not opened upon site load

@dvesh3

@dvesh3

This comment has been minimized.

Copy link
Contributor

@dvesh3 dvesh3 commented Dec 5, 2019

@AlternateIf thanks for reporting. Yes, I can only reproduce this on pimcore.demo and very random.

dvesh3 added a commit that referenced this issue Dec 5, 2019
@dvesh3

This comment has been minimized.

Copy link
Contributor

@dvesh3 dvesh3 commented Dec 5, 2019

Resolved by b8001f3

root cause: same url /admin/asset/get-image-thumbnail?id={assetId}&treepreview=true used for both grid preivew & tree preview. so when you move quickly over tree grid which then calls the same image url and moves out then it cancels the request which leads to corrupted image in grid preview.
image

Fix: Added extra param to grid preview image url

@dvesh3 dvesh3 closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.