Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks on bulk objects save #5361

Open
FredoVelcro opened this issue Dec 2, 2019 · 5 comments

Comments

@FredoVelcro
Copy link

@FredoVelcro FredoVelcro commented Dec 2, 2019

We are importing lots of objects (more than 100000) and the server memory keep increasing.
We tried many things to localize the origin of the problem, and it seems to be in the save() method/process itself.

What we tried to free memory :

  • unset the objects vars upon completed save() or finish using it
  • use \Pimcore::collectGarbage(); every X turns (ex: 100, 500, 1000, 5000 etc)
  • use Version::disable(); eahc time before $myObject->save();
  • use native calls of gc_* PHP garbage functions

and nothing changed...!
The only thing that prevent the memory growing was...commenting the save() call..

Can you tell us if you did some changes that could affect this since version 6.2.3 ? (DAO ?)

Best regards,

Fred

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor

@dpfaffenbauer dpfaffenbauer commented Dec 2, 2019

#3104

@dvesh3

This comment has been minimized.

Copy link
Contributor

@dvesh3 dvesh3 commented Dec 2, 2019

Long story, short #3104 (comment)

@dpfaffenbauer

This comment has been minimized.

Copy link
Contributor

@dpfaffenbauer dpfaffenbauer commented Dec 2, 2019

But: what I don't get is, why doesn't that happen with Doctrine ORM? That also uses doctrine/dbal?

@FredoVelcro

This comment has been minimized.

Copy link
Author

@FredoVelcro FredoVelcro commented Dec 2, 2019

we did not have the problem with Pimcore 6.2.3 ...

@brusch

This comment has been minimized.

Copy link
Member

@brusch brusch commented Dec 2, 2019

@FredoVelcro if possible it would be nice if you can do a profiler comparison between the old version and 6.2.3, imho that's the only way how we can find out what the problem actually is.

@brusch brusch changed the title Big memory leaks on bulk objects save Memory leaks on bulk objects save Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.