Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator in filter method of data object listing breaks implementation #5584

Closed
deltatag opened this issue Jan 15, 2020 · 2 comments
Closed

Operator in filter method of data object listing breaks implementation #5584

deltatag opened this issue Jan 15, 2020 · 2 comments

Comments

@deltatag
Copy link
Contributor

@deltatag deltatag commented Jan 15, 2020

Expected behavior

Usage of class listing with field name "operator" should be possible

Actual behavior

Using a listing of a class with field name "operator" fails due to two method parameters with same name generated for listing.

This problem was created with implementation of #4351 / #4355

Steps to reproduce

  • Create class with field name "operator" (e.g. input)
  • Use listing to load objects
  • Fails due to compile error "Compile Error: Redefinition of parameter $operator"

image

Solution

All Pimcore used parameters should be blocked when creating the class definition (e.g. same as with reserved field names)

@weisswurstkanone

This comment has been minimized.

Copy link
Contributor

@weisswurstkanone weisswurstkanone commented Jan 15, 2020

@BlackbitNeueMedien , can you have a look ?

@weisswurstkanone

This comment has been minimized.

Copy link
Contributor

@weisswurstkanone weisswurstkanone commented Jan 15, 2020

fixed via #5585

#76 | 07/01/2020 - 17/01/2020 automation moved this from To do to Done Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.