Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document\Tag Public properties #6050

Open
dpfaffenbauer opened this issue Mar 17, 2020 · 1 comment
Open

Document\Tag Public properties #6050

dpfaffenbauer opened this issue Mar 17, 2020 · 1 comment
Labels
Milestone

Comments

@dpfaffenbauer
Copy link
Contributor

@dpfaffenbauer dpfaffenbauer commented Mar 17, 2020

Remove Public Properties there as well to be consistent with DataObjects and Assets (https://github.com/pimcore/pimcore/blob/master/models/Document/Tag/Relation.php#L58).

It is quite painful sometimes to work with that in templates, you always have to remember where to use a getter or the property name itself (which for private/protected properties, symfony checks for a getter and uses that one)

@brusch brusch added this to the 7.0.0 milestone Mar 17, 2020
@brusch brusch added the Task label Mar 17, 2020
@brusch

This comment has been minimized.

Copy link
Member

@brusch brusch commented Mar 17, 2020

Makes sense, topic for v7 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.