Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and Export Icons seem to be wrong #6098

Closed
knoepfchen23 opened this issue Mar 26, 2020 · 1 comment
Closed

Import and Export Icons seem to be wrong #6098

knoepfchen23 opened this issue Mar 26, 2020 · 1 comment

Comments

@knoepfchen23
Copy link
Contributor

@knoepfchen23 knoepfchen23 commented Mar 26, 2020

We are actually using the pimcore icons for „export“ and „import“, the colored and the non-colored (black & white) ones. The colored icons seem to be inverted the wrong way. The non-colored seem to be right.

The direction of the arrow of the export icon must be outside the element / circle / square.
The direction of the arrow of the import icon must be inside the element / circle / square.

In these lines, you can see that it’s interchanged:

.pimcore_icon_export -> /bundles/pimcoreadmin/img/flat-color-icons/internal.svg
.pimcore_icon_import -> /bundles/pimcoreadmin/img/flat-color-icons/external.svg
1197 - 1203 /bundles/AdminBundle/Resources/public/css/icons.css

The same is for ".pimcore_nav_icon_export" and ".pimcore_nav_icon_import". (Lines: 406 - 412)

@NiklasBr

This comment has been minimized.

Copy link
Contributor

@NiklasBr NiklasBr commented Mar 31, 2020

So, I created a PR to fix this, but I can also understand why the current state is why it is. The person who initially choose these icons probably considered the upwards/downwards direction of the arrows to be the primary indicator of function. But I agree that it is actually the direction of the arrow in relation to the secondary figure (the circle) which is the primary indicator of function.

A more thourough "fix" would probably mean redrawing the icons altogether to align both of these bearers of information.

@brusch brusch closed this in #6119 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.