[Security] Fix Admin Translation Export SQL Injection #14968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Additional info
WHAT
This pull request enhances the translation controller by using safer and more flexible SQL queries, and by handling errors gracefully. It also allows more advanced filtering options for the translation grid.
HOW
SyntaxErrorExceptionclass to handle syntax errors in SQL queries (link)exportActionandtranslationsActionmethods to use array format ofgetGridFilterConditionmethod and catchSyntaxErrorException(link, link, link, link)getGridFilterConditionmethod to return array with condition and parameters, use placeholders, and support admin filter (link, link, link, link, link, link)