Fix snippet personalized content content cleanup #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusch
reviewed
Apr 26, 2019
| // check if there's a document in session which should be used as data-source | ||
| // see also PageController::clearEditableDataAction() | this is necessary to reset all fields and to get rid of | ||
| // outdated and unused data elements in this document (eg. entries of area-blocks) | ||
| $snippetSession = Session::useSession(function (AttributeBagInterface $session) use ($snippet) { |
There was a problem hiding this comment.
@dvesh3 To avoid duplicate code we should move this function to DocumentControllerBase and use it in both PageController and SnippetController, that should be easily possible as far as I can see.
Thanks!
weisswurstkanone
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Fix snippet personalized content content cleanup * Refactor to avoid duplicate code * Revert unused models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #4002
Additional info