Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elements] Fix: Allow mixed bind params for listing conditions #4280

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Projects
2 participants
@dvesh3
Copy link
Contributor

commented Apr 25, 2019

Changes in this pull request

Fixes bind params issue introduced in #4265

Additional info

@dvesh3 dvesh3 added the Bug label Apr 25, 2019

@dvesh3 dvesh3 added this to the 5.8.0 milestone Apr 25, 2019

@dvesh3 dvesh3 added this to In progress in 23/04/2019 - 26/04/2019 via automation Apr 25, 2019

@fashxp fashxp merged commit a27b660 into master Apr 25, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

23/04/2019 - 26/04/2019 automation moved this from In progress to Done Apr 25, 2019

@fashxp fashxp deleted the fix-mixed-params-listing-condition-binding branch Apr 25, 2019

NiklasBr added a commit to NiklasBr/pimcore that referenced this pull request May 3, 2019

Head into fork (#1)
* Grid: "Batch edit all" doesn't edit all or to many items (pimcore#4168)

* pimcore.object.helpers.gridTabAbstract.batchPrepare doesn't process all items in grid.

* Code cleanup

* refixed pimcore#4090 - [ecommerce] On ES6, filters based on number return errors

* [Workflow] `supports` class_exists validation problem/error - fixes pimcore#4110

* [Deployment] add customlayout cli import (pimcore#4131)

* Coding Standards Fixer Bot

* [Thumbnails] introduce asTexture mode and fix broken setBackgroundImage method for system thumbnails (pimcore#4185)

This patch fixes two bugs:
 - set real image path for background image
 - use textureimage to set background image independent of background image size

* [Image Thumbnails] made `asTexture` background image option also available for custom thumbnail configs

* [Asset] delete temporary files in __destruct()

* [Asset|Document] cleaned up __sleep() methods

* [Maintenance] Log-Rotate doesn't work as expected (daily rotate) - fixes pimcore#4188

* [Asset] Custom-Settings are not saved, because of too big serialized data - fixes pimcore#4190

* [Asset] Video Converter: be more verbose - include command in log file

* [DataObjects] ManyToOne: unable to null out the localized value pimcore#4192

* [DataObjects] PathFormatter for ManyToOne relation always marks object as dirty pimcore#4117

* Coding Standards Fixer Bot

* re fixed pimcore#4133 - [DataObjects] Markup in Grids in Select Fields is not working anymore
and fixed a few further XSS stuff

* fix admin translation javascript issues - bug fix when translations are not loaded

* [Data Object] Restore Layout Issues - fixes custom layouts & removed dependency to localStorage, as it isn't needed at all - see pimcore#4198

* [Data Object] Restore Layout Issues - renamed uiStates to uiState - see pimcore#4198

* [Data Object] Restore Layout Issues - fixes localized fields with language selection - fixes pimcore#4198

* Add configuration for custom admin login entry point

* [Data Object] it's not necessary to stringify the UI state - see pimcore#4198

* Add docs for custom admin entry point

* [Data Object] UI State recovery - possibility to ignore

* [Metadata] Add missing method doc in Predefined class

* use deepClone ^1.9, fixes pimcore#4203

* [Object] Unable to save localized field within block element - fixes pimcore#4202

* Custom admin entry point: use request event listener, to hide anything behind the pattern ^/admin

* Argument 1 of CustomAdminEntryPointCheckListener::__construct() has to be nullable

* Lazy load tags tree on tab activate pimcore#4195

* Reset cached counts in SessionCart (pimcore#4200)

Method Pimcore\Bundle\EcommerceFrameworkBundle\CartManager\AbstractCart::getItemCount() und getSubItemCount() cache the result, which in case if the SessionCart gets serialized and thus never updated.

This resets these values in case the cart gets modified.

* [Object] Many-to-many relations type: no not allow sorting in editmode grid

* [DOCS] fix S3 readme - fixes pimcore#4183

* Lazy load notes list

* [BackendSearch] restart save transaction if it fails

* Coding Standards Fixer Bot

* provide bundle name to determine correct action methods

* Filter option for many-to-many objects relations (pimcore#4194)

* fixed pimcore#4210 - Optimize relation loading in admin broken again

* [Asset] do not auto load downloadable thumbnail list in image detail view

* [Documents] do not autoload bundle, controller, action, template stores in UI

* [DataObjects] Allow multiple assignments on advanced (object) relations (pimcore#4189)

* [DataObjects] Allow multiple assignments on advanced relations pimcore#2022

* [DataObjects] Allow multiple assignments on advanced relations - Fix nicepath for Advnaced Many-to-Many Object Relations pimcore#2022

* [DataObjects] Allow multiple assignments on advanced relations - Fix nicepath for many to many relations pimcore#2022

* [DataObjects] Allow multiple assignments on advanced (object) relations - added tests

* [DataObjects] Allow multiple assignments on advanced relations - Fix index mismatch issues pimcore#2022

* [DataObjects] Allow multiple assignments on advanced relations - Add constant for rowId separator pimcore#2022

* [Document] fix reload issue on page edits

* Coding Standards Fixer Bot

* Show unreferenced assets (pimcore#4211)

* add checkbox in asset's list view to show unreferenced assets

* Revert "Show unreferenced assets (pimcore#4211)" - This reverts commit cb92c42

* Add option to load all linked translation documents

* Fix create translations modals in document language overview

* Show unreferenced assets (Follow-up of pimcore#4211) (pimcore#4222)

* Make workflow name available in place configs and global actions. (pimcore#4220)

* Placeholder support in workflows. (pimcore#4218)

* Placeholder support in workflows.

* Move PlaceholderProcessor and test to Pimcore CoreBundle.

* Add example in readme.

* Make filtering of unique places overridable. (pimcore#4224)

* Coding Standards Fixer Bot

* Feature "Export all" in grid CSV export (pimcore#4144)

* re fixed pimcore#4226 - [DataObject] AdvancedManyToManyObject metadata fields not loaded in admin when no visible fields are defined

* pimcore#4228 - added comment

* renamed only_unused to only_unreferenced

* add postAdd(Object|Document)Tree event for the backend ui (pimcore#4227)

* add postAddObject event for the backend ui

*  - rename to postAddObjectTree
 - add an event for documents as well

* Localized fields - split view (pimcore#4212)

* Object editing split view for Localized Fields pimcore#3054

* Object editing split view for Localized Fields pimcore#3054

* fixed adding title to wrapper

* Object editing split view for Localized Fields pimcore#3054

* Object editing split view for Localized Fields pimcore#3054

* Object editing split view for Localized Fields pimcore#3054 - when reloading object after applying split view, currently active custom layout should be remembered

* Do not replace a replaced link in Glossary (pimcore#4217)

* Do not replace a replaced link in Glossary

* shortened regex

* [Object] Localized fields: do not restore UI state on reload when using select based layout

* [Object] Localized fields: split view restore ui layout after changing view

* Update zh_Hans.json (POEditor.com)

* Update cs.json (POEditor.com)

* Update nl.json (POEditor.com)

* Update fr.json (POEditor.com)

* Update de.json (POEditor.com)

* Update it.json (POEditor.com)

* Update fa.json (POEditor.com)

* Update pl.json (POEditor.com)

* Update sk.json (POEditor.com)

* Update es.json (POEditor.com)

* Update sv.json (POEditor.com)

* Update sv_FI.json (POEditor.com)

* Update tr.json (POEditor.com)

* Update cs.extended.json (POEditor.com)

* Update nl.extended.json (POEditor.com)

* Update fr.extended.json (POEditor.com)

* Update de.extended.json (POEditor.com)

* Update it.extended.json (POEditor.com)

* Update pl.extended.json (POEditor.com)

* Update sk.extended.json (POEditor.com)

* Update es.extended.json (POEditor.com)

* Release 5.7.3

* Fix not-editable reverseManyToManyObjectRelations

* added some more tests

* moved some translations to extended translations

* Revert "Use DeepClone 1.9" (pimcore#4231)

* Coding Standards Fixer Bot

* Avoid MySQL index size size issue documented here: pimcore#4233

* [WebsiteSettings] getData() should lazy load relations (pimcore#4097)

* [WebsiteSettings] getData should lazy load like Property class
* [WebsiteSettings] Fix SettingsController
* Fix usage over \Pimcore\Config\Config

* fix pimcore#4235

* [DOCS] Added upgrade note for upgrade from < 5.4 to >= 5.4 regarding the PHP 7.1 serialization bug, resolves pimcore#4232

* Fix resend email

* Fix email log refactor migration

* Allow display of new email log types

* [Objects] Many-to-many Object Relation: Column `Reference` stays empty on assignment pimcore#4237

* Fix condition for all translations menu option

* [Element] Show notice message before closing a changed element pimcore#3997

* [Image-Thumbnails] Race condition while generating thumbnail - fixes pimcore#4027

* [DataObjects] Images in gallery have invalid size when gallery located in collapsed fieldset pimcore#4238

* [Image-Thumbnails] Race condition for recursive mkdir - fixes pimcore#4011

* fixes missing return value, see pimcore#4011

* [DataObjects] Fix empty check for slider data type

* [Object] Show appropriate Error Message when deleting fails pimcore#3902

* Coding Standards Fixer Bot

* fixed pimcore#4246 - [Ecommerce] Extend Tenant Category handling optionally to SubObjectIds

* [DataObject] Refactor and add exception argument to failed events

* [Assets] Refactor and add exception argument to failed events

* [Documents] Refactor and add exception argument to failed events

* Add exception argument to delete failure events

* Fix tree reload after deleting elements (pimcore#4241)

* fix tree reload after deleting element

* only refresh the direct parent & do not remove the deleted nodes manually

* Fix tree page size issue on reload

* Add failed exceptions to save version actions

* Update docs

* Fixed Typo

* cleanup, fixed height in horizontal mode, fixed shown value in label when == NULL

* Classification store looses data when editing objects in grid mode and update them in edit mode pimcore#4179

* [Object] Grid: don't clear active filters when adding a new column pimcore#4108

* Integrate PDFreactor 10 API wrapper (pimcore#4252)

* Coding Standards Fixer Bot

* removed pimcore:update

* Add missing trims for email getters

* [DOCS] some fixes

* [Elements] Allow array parameter binding for listing conditions (pimcore#4265)

* [Elements] Add condition params type property in Abstract listing

* [Elements] Add parameter for condition params type

* Update docs

* Update 03_Working_with_PHP_API.md

* Cleanup DataObject controller (pimcore#4259)

* cleanup dead code from DataObject controller

* Correct code style and update phpDocs

* removed unused method getParentValue

* correct phpdocs

* Unique key constraint not considered when restoring from recycling bi… (pimcore#4261)

* Unique key constraint not considered when restoring from recycling bin pimcore#4219

* Unique key constraint not considered when restoring from recycling bin pimcore#4219 - use model factory

* Update Item.php

* [Documents] Area editable improvements (pimcore#4257)

* Add cancel button and allow dimension properties in area editable

* Update area editable docs

* Coding Standards Fixer Bot

* "Show in tree" not working because of utf8_bin - fixes pimcore#4269

* [DOCS] corrected wrong usage of $this->headLink() - fixes pimcore#4260

* Prevent select options without value (pimcore#4243)

* add checkbox in asset's list view to show unreferenced assets

* prevent options without value

* revert wrong commit

* remove autoCancel: true for Ext.grid.plugin.RowEditing because it is set by default anyway

* initially set option's value

* initially set option's value

* set "display value" as default "value"

* prevent multiple options with same value

* AbstractObject & Document: unpublished objects in getChildren vs. hasChildren pimcore#2128

* Fix document settings autoload

* Coding Standards Fixer Bot

* Es Bugfix - deleting items: (pimcore#4273)

- consider tenants
- consider missing items as valid

* Cannot programmatically fill&save localized field data if embedded in a block pimcore#4274

* added tests for object listings

* Update 03_HeadScript.md

No 'echo' needed if '<?=' tag is used.

* Add condition for non-array bind param types (pimcore#4280)

* [Elements] Fixed: locked elements should not be deleted (pimcore#4284)

* [Elements] Hide delete option from grid context menu if element is locked

* [Elements] Restrict deletion of locked element from API

* [DOCS] code highlighting

* Renamed Document::$hidePublished to Document::$hideUnPublished analogue to AbstractObject

* Coding Standards Fixer Bot

* Fix snippet personalized content content cleanup (pimcore#4270)

* Fix snippet personalized content content cleanup

* Refactor to avoid duplicate code

* Revert unused models

* [Maintenance] refactor maintenance (pimcore#3895)

* [Maintenance] deprecate old maintenance job and introduce new tagged services for identifiers. also extract all current core maintenance tasks into seperate maintenance files and remove Business Logic from models

* deprecate the SystemEvents::MAINTENANCE Event
implement EcommerceFramework Tasks with the new tag
add docs for maintenance tasks

* fix link to maintenance_tasks docs

* [Maintenance] fix Version Cleanup Task

* add missing CheckErrorLogDb Maintenance Task

* [Object] Refactored Path-Formatter to use DI (incl. BC Layer) (pimcore#3399)

* refactor Formatter: add interface and BC layer for old static formatters with deprecation log

* update path formatter docs for di

* add upgrade not for path-formatter and BC warning

* fix lost implementation

* remove duplicate readme entry

* implement interface correct

* change docs a bit to describe the preferred way for path formatters

* change label path formatter class to path formatter service

* fix lazy loading edit mode data

* Reverted changes to fix path formatter

* Update zh_Hans.json (POEditor.com)

* Update cs.json (POEditor.com)

* Update nl.json (POEditor.com)

* Update fr.json (POEditor.com)

* Update de.json (POEditor.com)

* Update it.json (POEditor.com)

* Update fa.json (POEditor.com)

* Update pl.json (POEditor.com)

* Update sk.json (POEditor.com)

* Update es.json (POEditor.com)

* Update sv.json (POEditor.com)

* Update sv_FI.json (POEditor.com)

* Update tr.json (POEditor.com)

* Update cs.extended.json (POEditor.com)

* Update nl.extended.json (POEditor.com)

* Update fr.extended.json (POEditor.com)

* Update de.extended.json (POEditor.com)

* Update it.extended.json (POEditor.com)

* Update pl.extended.json (POEditor.com)

* Update sk.extended.json (POEditor.com)

* Update es.extended.json (POEditor.com)

* Add cache configuration warning in docs

* Add param for batch prepare

* Coding Standards Fixer Bot

* [RecycleBin] Lazy loaded Relations are lost if object is deleted and restored pimcore#4293

* Add documentation for how to use pimcore_inc passed parameters in the view that is included

* Version 20181128074035 does no SQL migrations ... fix

* [DOCS] Upgrade note for 5.8 -> signature change of MaintenanceCommand issues warning

* Mark lazy fields loaded in restore process

* Fix twig syntax in documentation (pimcore#4295)

* Quantity Value Unit conversion (pimcore#4138)

* base unit and conversion factor for quantity value units

* lazy-load base unit

* bugfix when converting from and to base unit

* conversion offset

* do not change unit objects when converting (beware call-by-reference)

* update base unit store on unit update

* re-use pimcore.object.tags.quantityValue's store for base unit

* add empty select option

* write null to database if empty option got selected

* add foreign key for baseunit

* Specify converter service for each unit

* use converter service of base unit

* add database changes to install.sql

* allow providing Unit instead of unit ID in QuantityValue constructor

* allow providing Unit instead of unit ID in QuantityValue constructor

* allow providing Unit instead of unit ID in QuantityValue constructor

* add database changes to install.sql

* automatic quantity value conversion when changing unit while editing data object

* change column label "Converter" to "Converter service"

* catch exception and don't auto-convert if converter throws exception

* add quantity value unit conversion docs

* add quantity value unit conversion docs

* allow null to be returned

* add field configuration for automatic unit conversion

* resolve merge conflict

* Fixed an error in the documentation (pimcore#4302)

* Updates migration script for pimcore#4138 - caused issues on some systems ...

* AbstractObject: set all public properties to protected (pimcore#4303)

* AbstractObject: set all public properties to protected pimcore#4301

* AbstractObject: set all public properties to protected pimcore#4301

* AbstractObject: set all public properties to protected pimcore#4301

* AbstractObject & Document: unpublished objects in getChildren vs. hasChildren pimcore#2128

* [RecycleBin] Fixed dependencies on element restore (pimcore#4296)

* Remove target dependency cleanup on delete

* Fix DataObject relations cleanup in Sanitycheck command

* Revert disableDirtyDetection call

* Fix dirty detection of fields for element save

* Revert wrong commit

* Fix Advanced Relations load

* Fix Many to Many Relations

* Removed orphaned use statement

* AbstractObject & Document: unpublished objects in getChildren vs. hasChildren pimcore#2128

* recipient calculation newsletter panel (pimcore#4286)

* add calcuate function

* add calculation to sending panel

* Update NewsletterController.php

* Added batch edit options for Advanced Many-To-Many Relation meta fields (pimcore#4290)

* Add batch edit meta columns option for Advanced Many to Many Relations

* Hide batch selected option from system columns in Advanced Many to Many Object Relation

* Refactor common code for batch edit metadata

* Update notification controller routing annotations to Symfony core

* Coding Standards Fixer Bot

* Fix documents template setting load

* Update zh_Hans.json (POEditor.com)

* Update cs.json (POEditor.com)

* Update nl.json (POEditor.com)

* Update fr.json (POEditor.com)

* Update de.json (POEditor.com)

* Update it.json (POEditor.com)

* Update fa.json (POEditor.com)

* Update pl.json (POEditor.com)

* Update sk.json (POEditor.com)

* Update es.json (POEditor.com)

* Update sv.json (POEditor.com)

* Update sv_FI.json (POEditor.com)

* Update tr.json (POEditor.com)

* Update cs.extended.json (POEditor.com)

* Update nl.extended.json (POEditor.com)

* Update fr.extended.json (POEditor.com)

* Update de.extended.json (POEditor.com)

* Update it.extended.json (POEditor.com)

* Update pl.extended.json (POEditor.com)

* Update sk.extended.json (POEditor.com)

* Update es.extended.json (POEditor.com)

* composer.json branch-alias to 5.8-dev

* Release 5.8.0

* [Document] Hardlink: fixed signature of hasChildren()

* File::mkdir() doesn't work properly when open_basedir directive is used - fixes pimcore#4315

* [Maintenance] added `maintenance` alias for `pimcore:maintenance` command [BC] - fixes pimcore#4316

* [DOCS] Updated migration guide from pre 5.4 to 5.4 to avoid error messages - fixes pimcore#4307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.