Skip to content

Commit

Permalink
Remove needless Result from WebPushMessageBuilder::new
Browse files Browse the repository at this point in the history
closes #47
  • Loading branch information
andyblarblar committed Aug 21, 2023
1 parent c5a8e12 commit b3d9797
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>
let mut sig_builder = VapidSignatureBuilder::from_pem(file, &subscription_info)?.build()?;

//Now add payload and encrypt.
let mut builder = WebPushMessageBuilder::new(&subscription_info)?;
let mut builder = WebPushMessageBuilder::new(&subscription_info);
let content = "Encrypted payload to be sent in the notification".as_bytes();
builder.set_payload(ContentEncoding::Aes128Gcm, content);
builder.set_vapid_signature(sig_builder);
Expand Down
2 changes: 1 addition & 1 deletion examples/simple_send.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>

let subscription_info: SubscriptionInfo = serde_json::from_str(&contents).unwrap();

let mut builder = WebPushMessageBuilder::new(&subscription_info).unwrap();
let mut builder = WebPushMessageBuilder::new(&subscription_info);

if let Some(ref payload) = push_payload {
builder.set_payload(ece_scheme, payload.as_bytes());
Expand Down
6 changes: 3 additions & 3 deletions src/clients/request_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ struct ErrorInfo {
/// "xS03Fi5ErfTNH_l9WHE9Ig",
/// );
///
/// let mut builder = WebPushMessageBuilder::new(&info).unwrap();
/// let mut builder = WebPushMessageBuilder::new(&info);
///
/// //Build the request for isahc
/// let request = build_request::<isahc::Body>(builder.build().unwrap());
Expand Down Expand Up @@ -112,7 +112,7 @@ mod tests {

let info = serde_json::from_value(sub).unwrap();

let mut builder = WebPushMessageBuilder::new(&info).unwrap();
let mut builder = WebPushMessageBuilder::new(&info);

builder.set_ttl(420);
builder.set_urgency(Urgency::VeryLow);
Expand All @@ -139,7 +139,7 @@ mod tests {

let info = serde_json::from_value(sub).unwrap();

let mut builder = WebPushMessageBuilder::new(&info).unwrap();
let mut builder = WebPushMessageBuilder::new(&info);

builder.set_payload(ContentEncoding::Aes128Gcm, "test".as_bytes());

Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
//! let mut sig_builder = VapidSignatureBuilder::from_pem(file, &subscription_info)?.build()?;
//!
//! //Now add payload and encrypt.
//! let mut builder = WebPushMessageBuilder::new(&subscription_info)?;
//! let mut builder = WebPushMessageBuilder::new(&subscription_info);
//! let content = "Encrypted payload to be sent in the notification".as_bytes();
//! builder.set_payload(ContentEncoding::Aes128Gcm, content);
//! builder.set_vapid_signature(sig_builder);
Expand Down
6 changes: 3 additions & 3 deletions src/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ impl<'a> WebPushMessageBuilder<'a> {
///
/// All parameters are from the subscription info given by browser when
/// subscribing to push notifications.
pub fn new(subscription_info: &'a SubscriptionInfo) -> Result<WebPushMessageBuilder<'a>, WebPushError> {
Ok(WebPushMessageBuilder {
pub fn new(subscription_info: &'a SubscriptionInfo) -> WebPushMessageBuilder<'a> {
WebPushMessageBuilder {
subscription_info,
ttl: 2_419_200,
urgency: None,
payload: None,
vapid_signature: None,
})
}
}

/// How long the server should keep the message if it cannot be delivered
Expand Down

0 comments on commit b3d9797

Please sign in to comment.