Lock Install to Python 2.x #10
Conversation
Temporarily lock down apt install of mopidy and mopidy-spotify to version that support python 2.x Add python/pip check to verify that pip exists and is from python 2.x
|
I took the liberty of adding a python/pip 2.x check along with the proposed apt fixes. I figured we can just flip |
|
I'm not in a place today where I can test this, but it looks good readding through it. If needed, I could test this tomorrow (Jan 2, PST). |
|
Looks like stomps all over your previous version-pinned install and doesn't heed "apt-hold". I'll see if I can work around that. Although I wonder if it's truly necessary- the objective is to reset the installed config file to the distro default before appending custom config to it. I was installing on a non-clean system, so I get to find all the edge case bugs :D I suspect just changing that line to the following will work: |
|
I'm happy to merge this and make the minor change to the @docmollo if you're happy to give it a go, I'd appreciate your input too before I hit merge! |
|
@Gadgetoid got it, we (@docmollo and I) didn't test an existing installation, just a fresh one. I'll hit up @docmollo and see if we can verify the conf reset with |
…r-lite and pip check Tokenize package versions Add package version to mopidy conf reset Tokenize pip bin path in prep for switch to python3 pip3
Add inform and echo lines to make output easier to eye parse.
|
OK....after many gyrations and updates/fixes, I think we have a winner. I've tested the latest commit from a fresh Raspbian Buster Lite install and all works as expected. I say merge! Quick, before it breaks again! |
|
@Gadgetoid I tested along with @docmollo. While he did a fresh install, I installed over my existing messy not-so-fresh install and everything still worked. So I think we are good! And let us know if we can help with anything else, this was fun! |
|
Really great stuff- it's been a pleasure having your input. I've got the migrations for Mopidy-PiDi and Mopidy-Raspberry-GPIO to Python 3 in hand, but with Iris not updated to Python 3 yet there's not much I can do but twiddle my thumbs and wait. (I wish I had time to volunteer to help!) Thanks all! One thing we'd like to do long term is make this even easier for end-users to install. Maybe shipping a Pirate Audio distro based on Raspbian (since it's the most readily extensible jumping off point for users wanting to modify/enhance their project). |
|
You're welcome, @Gadgetoid. Happy I could help out! Looking at Iris issue #356, it looks like they're making progress and he mentioned hopes to have something by the end of January. 🤞 With regard to the custom Raspbian, do you mean like what you did for the Keybows? That would be interesting and cool. I've never messed around with creating my own Raspbian (or even Linux) distro, but this sounds like an interesting thing I should mess around with. |
|
Well shoot...just found a bug. I just ran through another clean install this morning to verify and it is indeed an issue. Once everything is done, the hold on mopidy is wiped out. I suspect it's the step near the end that resets the mopidy config file. This could be easily fixed by adding one last apt-mark at the very end of the install script....or perhaps wait until then to run that command. For what it's worth, the hold on mopidy-spotify still exists at the end of the install. @dkinon can you push this fix? If not, I'm sure I can get an environment setup and do it. |
Temporarily lock down apt install of mopidy and mopidy-spotify to version that support python 2.x
Add python/pip check to verify that pip exists and is from python 2.x