Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent order of find/grep/search results #73

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@pimterry
Copy link
Owner

commented Aug 30, 2019

Fixes #72

Based on your comment @primis, I think this is simply non-deterministic: on my machine it seems to fail when running the commands manually or through the test suite, even though it used to work.

I propose we start just explicitly sorting results, which makes this test pass (on Travis & my machine at least, and in theory everywhere), and seems like a nice & sensible thing to do anyway. What do you think?

@primis

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

Seems good, I'm gonna merge it

@primis primis merged commit e3a9eab into master Sep 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pimterry pimterry deleted the fix-find-order branch Sep 4, 2019

@pimterry

This comment has been minimized.

Copy link
Owner Author

commented Sep 4, 2019

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.