Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unplayable tracks in a browse listing cause the incorrect track to be selected #124

Closed
colinnuk opened this issue Oct 1, 2015 · 1 comment
Assignees

Comments

@colinnuk
Copy link

colinnuk commented Oct 1, 2015

Noticed this with SoundCloud, but if there are unplayable tracks (some tracks appear in the liked list but turn out to be 404 errors when you try and use their URIs) in the browse view, then they will be removed from the tracklist in Mopidy. This means that the client side code to play the selected track from the list selects the wrong track as the index doesn't get updated.

The code I changed uses track URI to select the track, rather than incrementing thru a tracklist.

I submitted my change here: https://github.com/colinnuk/mopidy-musicbox-webclient/commit/2eb4141f72ce1ec2ba60b5953ab150d2c9c7b268

But I just realised your develop branch has a rather different function entirely, which could fix the issue?

@jcass77
Copy link
Member

jcass77 commented Feb 13, 2016

If you could create a pull request against the latest develop branch then we can probably take another look at this issue?

@jcass77 jcass77 self-assigned this Apr 16, 2016
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Apr 24, 2016
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants