New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Store hashes of item content #257

Closed
untitaker opened this Issue Sep 1, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@untitaker
Member

untitaker commented Sep 1, 2015

This should prevent vdirsyncer from unnecessarily entering conflict resolution mode on e.g. filesystems that have funky mtimes.

I wonder whether vdirsyncer should issue performance warnings if etags change but the item content didn't.

Related to #127, brought up by @hobarrera

@untitaker untitaker added this to the 1.0 milestone Sep 1, 2015

@untitaker untitaker closed this in 1d5216f Nov 28, 2015

@untitaker

This comment has been minimized.

Member

untitaker commented Nov 28, 2015

Latest master actually does this. This means that you can touch local files randomly and vdirsyncer will still not hit the network because the content didn't change. It will, however, burn a lot of CPU power if you do this for a lot of files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment