New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pair configuration: `collections = null` is not a good default. #328

Open
untitaker opened this Issue Feb 3, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@untitaker
Member

untitaker commented Feb 3, 2016

null implies that the user entered direct URLs and paths to a collection. This is useful behavior in the case where collection discovery is completely broken on the server, but it is only rarely used and therefore a bad default. We have two options: PLAN:

  • Require a value, no default done in 0.9.0
  • Change the default, I suggest ["from a", "from b"] 1.0

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lfam

This comment has been minimized.

Contributor

lfam commented Feb 4, 2016

On Wed, Feb 03, 2016 at 02:05:29PM -0800, Markus Unterwaditzer wrote:

null implies that the user entered direct URLs and paths to a
collection. This is useful behavior in the case where collection
discovery is completely broken on the server, but it is only rarely
used and therefore a bad default. We have two options:

  • Change the default, I suggest ["from a", "from b"]

Since vdirsyncer sync syncs all configured pairs, then I think it
makes sense for this default to be to sync all collections from both
sides, which I think is what you are suggesting here.

  • Require a value, no default

Reply to this email directly or view it on GitHub:
#328

@untitaker

This comment has been minimized.

Member

untitaker commented Feb 4, 2016

which I think is what you are suggesting here

Yes, but...

vdirsyncer sync syncs all configured pairs and collections, but the collections parameter defines the "configured collections". I'm not sure your analogy holds.

  • All collections from both sides = All collections that are discoverable (through the DAV user account) or for which a local folder exists
  • All configured collections = What is defined in collections.
@lfam

This comment has been minimized.

Contributor

lfam commented Feb 4, 2016

On Thu, Feb 04, 2016 at 11:33:08AM -0800, Markus Unterwaditzer wrote:

which I think is what you are suggesting here

Yes, but...

vdirsyncer sync syncs all configured pairs and collections, but the collections parameter defines the "configured collections". I'm not sure your analogy holds.

  • All collections from both sides = All collections that are discoverable (through the DAV user account) or for which a local folder exists
  • All configured collections = What is defined in collections.

You're right, that is different.


Reply to this email directly or view it on GitHub:
#328 (comment)

@untitaker

This comment has been minimized.

Member

untitaker commented Feb 11, 2016

In #331 I've decided to explicitly require the collections parameter for now. We may re-add a default later on, but I fear that simply changing the default would break user's configuration in too subtle ways.

untitaker added a commit that referenced this issue Feb 12, 2016

@untitaker

This comment has been minimized.

Member

untitaker commented Feb 15, 2016

0.9 is released without default, next release will be with new default.

@untitaker untitaker added this to the 1.0 milestone Feb 18, 2016

@untitaker untitaker added ready in progress and removed ready labels Mar 9, 2016

@untitaker untitaker removed this from the 1.0 milestone Apr 28, 2016

@untitaker

This comment has been minimized.

Member

untitaker commented Apr 28, 2016

Removing from 1.0 milestone since re-adding a default is not a breakage. However, I wonder if we ever should readd a default at all.

@untitaker untitaker added this to the 1.0 milestone Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment