Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user before synchronization if storage path was changed and new path is empty #42

Closed
jmehne opened this issue May 1, 2014 · 1 comment

Comments

@jmehne
Copy link
Contributor

@jmehne jmehne commented May 1, 2014

vdirsyncer can rather unexpectedly (from a user perspective :) ) delete all events from a server:

  1. Create a storage pair between an (empty) local and a remote storage.
  2. Make an initial sync -> everything is fetched from the remote storage, great!
  3. Change the local storage path in the config file and create that directory
  4. Resync -> all events are deleted from the remote storage

Expected behaviour: Detect that the storage path was changed and fetch everything from the server again.

A very simple fix might be to detect that a storage directory is empty but a status file exists and to at least prompt the user if he is really sure to delete everything from the server.

@untitaker untitaker closed this in d906aa3 May 1, 2014
@untitaker
Copy link
Member

@untitaker untitaker commented May 1, 2014

This is fixed now. vdirsyncer now requires --force-delete ... if it should synchronize two storages where one has been emptied.

untitaker added a commit that referenced this issue May 14, 2014
  - Introduced changelogs.

  - Many bugfixes.

  - Many doc fixes.

  - vdirsyncer now doesn't necessarily need UIDs anymore for syncronization.

  - vdirsyncer now aborts if one collection got completely emptied between two
    syncronizations. See #42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants