Zimbra address book with space in name confuses urlquoting

[davidfraser]

I have several address books with spaces in their names. If I configure them in the categories list with a space:

categories = Contacts,Emailed Contacts

then the _normalize_href function assertion x.startswith(self.session.url) fails, because href and x (the result of urljoin(session.url, href)) contain the quoted version of the category (Emailed%20Contacts), but session.url contain the unquoted version.
If I rather configure the categories list with a urlquoted-name:

categories = Contacts,Emailed%20Contacts

then the assertion still dies, because href and x now end up containing the unquoted version of the category...

[davidfraser]

Workarounds in zimbra-error-logging that change the asserts to a warning - obviously this assert is meant to catch a security violation so a better solution is needed

[davidfraser]

In addition, if the server is queried with a URL with a space in, it gives an HTTP error:

java.lang.IllegalArgumentException: Illegal character in path at index 28: /dav/acnt@server.com/Emailed Contacts/e5d2662d-ea83-4bc0-80f5-8ed6a482c359:24778.vcf
    at java.net.URI.create(URI.java:859)

[untitaker]

Please try out the spaces branch.

[untitaker]

Any updates on this?

[DmitrySandalov]

Got the same exception on calendar sync:

Unhandled exception occured while syncing bob_calendar.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/cli.py", line 333, in sync_collection
force_delete=status_name in force_delete
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/sync.py", line 129, in sync
list_b = prepare_list(storage_b, b_href_to_status)
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/sync.py", line 76, in prepare_list
prefetch(storage, rv, download)
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/sync.py", line 86, in prefetch
for href, item, etag in storage.get_multi(hrefs):
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/storage/dav.py", line 312, in get_multi
hrefs = [self._normalize_href(href) for href in hrefs]
File "/usr/local/lib/python2.7/dist-packages/vdirsyncer/storage/dav.py", line 297, in _normalize_href
assert x.startswith(self.session.url)
AssertionError

config+launch in debug mode:
https://gist.github.com/DmitrySandalov/0c4bad0ce6ec7d1ea257

[untitaker]

Fixed in version 0.2.2.

[davidfraser]

Sorry for slow reply; latest versions definitely work correctly - thanks!

----- Original Message -----

From: "Markus Unterwaditzer" notifications@github.com
To: "untitaker/vdirsyncer" vdirsyncer@noreply.github.com
Cc: "David Fraser" davidf@sjsoft.com
Sent: Monday, 14 July, 2014 5:03:48 PM
Subject: Re: [vdirsyncer] Zimbra address book with space in name confuses urlquoting (#87)

Any updates on this?
—
Reply to this email directly or view it on GitHub .

David Fraser
Technical Advisor
j5 International (Pty) Ltd

[untitaker]

Glad to hear that it works, and you're welcome!