Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: support client certificates #183

Merged
merged 1 commit into from Feb 26, 2015
Merged

Conversation

@mathstuf
Copy link
Contributor

@mathstuf mathstuf commented Feb 25, 2015


Tested with Davical+nginx locally.

@mathstuf
Copy link
Contributor Author

@mathstuf mathstuf commented Feb 25, 2015

Addresses #182.

@untitaker
Copy link
Member

@untitaker untitaker commented Feb 25, 2015

Thanks for this patch!

  • I think auth_cert is a more fitting name, because then all auth-related stuff starts with auth_. We also support JSON lists in the config, so only one param is needed, and the user can use both PEM and key/cert formats (see cert param in http://www.python-requests.org/en/latest/api/#requests.request)
  • Please add an example to the docs you added, for both formats.
  • Please also add this parameter to HttpStorage. There's also a shared docstring in there, HTTP_STORAGE_PARAMETERS. Add some docs for that parameter there too.
Password-protected keys are not supported.
@mathstuf mathstuf force-pushed the mathstuf:client-certs branch from 6ea49ea to 9223899 Feb 26, 2015
@mathstuf
Copy link
Contributor Author

@mathstuf mathstuf commented Feb 26, 2015

Updated.

@untitaker untitaker merged commit 9223899 into pimutils:master Feb 26, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@untitaker
Copy link
Member

@untitaker untitaker commented Feb 26, 2015

Awesome, thanks!

untitaker added a commit that referenced this pull request Feb 26, 2015
@mathstuf mathstuf deleted the mathstuf:client-certs branch Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants