Skip to content

ssl: support client certificates - #183

Merged
untitaker merged 1 commit into
pimutils:masterfrom
mathstuf:client-certs
Feb 26, 2015
Merged

untitaker merged 1 commit into
pimutils:masterfrom
mathstuf:client-certs

Conversation

@mathstuf

Copy link
Copy Markdown
Contributor

Tested with Davical+nginx locally.

@mathstuf

Copy link
Copy Markdown
Contributor Author

Addresses #182.

@untitaker

Copy link
Copy Markdown
Member

Thanks for this patch!

  • I think auth_cert is a more fitting name, because then all auth-related stuff starts with auth_. We also support JSON lists in the config, so only one param is needed, and the user can use both PEM and key/cert formats (see cert param in http://www.python-requests.org/en/latest/api/#requests.request)
  • Please add an example to the docs you added, for both formats.
  • Please also add this parameter to HttpStorage. There's also a shared docstring in there, HTTP_STORAGE_PARAMETERS. Add some docs for that parameter there too.

Password-protected keys are not supported.
@mathstuf

Copy link
Copy Markdown
Contributor Author

Updated.

@untitaker
untitaker merged commit 9223899 into pimutils:master Feb 26, 2015
@untitaker

Copy link
Copy Markdown
Member

Awesome, thanks!

untitaker added a commit that referenced this pull request Feb 26, 2015
@mathstuf
mathstuf deleted the client-certs branch February 27, 2015 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants