Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --config-file option. #409

Merged
merged 1 commit into from Apr 7, 2016
Merged

Add a --config-file option. #409

merged 1 commit into from Apr 7, 2016

Conversation

@lucc
Copy link
Contributor

@lucc lucc commented Apr 7, 2016

No description provided.

@untitaker
Copy link
Member

@untitaker untitaker commented Apr 7, 2016

Implementation looks solid and I've been meaning to add this myself. I'd like to have it named --config though, what do you think?

On 7 April 2016 12:17:32 CEST, Lucas Hoffmann notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

#409

-- Commit Summary --

  • Add a --config-file option.

-- File Changes --

M vdirsyncer/cli/init.py (6)
M vdirsyncer/cli/config.py (7)

-- Patch Links --

https://github.com/pimutils/vdirsyncer/pull/409.patch
https://github.com/pimutils/vdirsyncer/pull/409.diff


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#409

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@lucc
Copy link
Contributor Author

@lucc lucc commented Apr 7, 2016

Fine with me, will amend it.

@lucc lucc force-pushed the lucc:config branch from d6fd395 to 4f8ed93 Apr 7, 2016
@geier
Copy link
Member

@geier geier commented Apr 7, 2016

Quoting Markus Unterwaditzer (2016-04-07 15:34:39)

Implementation looks solid and I've been meaning to add this myself. I'd like to have it named --config though, what do you think?

agree.

@untitaker
Copy link
Member

@untitaker untitaker commented Apr 7, 2016

Sorry I forgot, could you add a changelog as well? Including a PR reference like in previous entries. Thanks!

@lucc lucc force-pushed the lucc:config branch from 4f8ed93 to 10cc4b1 Apr 7, 2016
@lucc
Copy link
Contributor Author

@lucc lucc commented Apr 7, 2016

done

@untitaker
Copy link
Member

@untitaker untitaker commented Apr 7, 2016

@homu r+

@homu
Copy link
Contributor

@homu homu commented Apr 7, 2016

📌 Commit 10cc4b1 has been approved by untitaker

homu added a commit that referenced this pull request Apr 7, 2016
Add a --config-file option.

None
@homu
Copy link
Contributor

@homu homu commented Apr 7, 2016

Testing commit 10cc4b1 with merge 45ba17d...

@homu
Copy link
Contributor

@homu homu commented Apr 7, 2016

💔 Test failed - status

@untitaker
Copy link
Member

@untitaker untitaker commented Apr 7, 2016

Bleh, see #410.

@homu retry

homu added a commit that referenced this pull request Apr 7, 2016
Add a --config-file option.

None
@homu
Copy link
Contributor

@homu homu commented Apr 7, 2016

Testing commit 10cc4b1 with merge f8a3961...

@homu
Copy link
Contributor

@homu homu commented Apr 7, 2016

☀️ Test successful - status

@homu homu merged commit 10cc4b1 into pimutils:master Apr 7, 2016
2 of 3 checks passed
2 of 3 checks passed
codecov/project 82.63% (-4.66%) compared to 69b88dd at 87.29%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@homu
homu Test successful
Details
@lucc lucc deleted the lucc:config branch Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants