DAV: Don't violate Storage API #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
force-pushed
the
no-null-etag
branch
from
e456afb
to
a9d2118
Compare
The implementation of #476 is problematic as it returns None. `vdirsyncer.sync` has internal assertions that this is a string, which is why we get a crash like this: error: Unknown error occured for cal/markus@unterwaditzer.net: error: Use `-vdebug` to see the full traceback. debug: File "/home/untitaker/projects/vdirsyncer/vdirsyncer/cli/tasks.py", line 66, in sync_collection debug: force_delete=force_delete debug: File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 228, in sync debug: action(a_info, b_info, conflict_resolution) debug: File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 276, in inner debug: assert isinstance(dest_etag, (bytes, text_type)) Discovered in #467
untitaker
force-pushed
the
no-null-etag
branch
from
a9d2118
to
4d65cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The implementation of #476 is problematic as it returns None.
vdirsyncer.synchas internal assertions that this is a string, whichis why we get a crash like this:
Discovered in #467