New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV: Don't violate Storage API #492

Merged
merged 1 commit into from Aug 19, 2016

Conversation

Projects
None yet
1 participant
@untitaker
Member

untitaker commented Aug 19, 2016

The implementation of #476 is problematic as it returns None.
vdirsyncer.sync has internal assertions that this is a string, which
is why we get a crash like this:

error: Unknown error occured for cal/markus@unterwaditzer.net:
error: Use `-vdebug` to see the full traceback.
debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/cli/tasks.py", line 66, in sync_collection
debug:     force_delete=force_delete
debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 228, in sync
debug:     action(a_info, b_info, conflict_resolution)
debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 276, in inner
debug:     assert isinstance(dest_etag, (bytes, text_type))

Discovered in #467

@untitaker untitaker force-pushed the no-null-etag branch from e456afb to a9d2118 Aug 19, 2016

DAV: Don't violate Storage API
The implementation of #476 is problematic as it returns None.
`vdirsyncer.sync` has internal assertions that this is a string, which
is why we get a crash like this:

    error: Unknown error occured for cal/markus@unterwaditzer.net:
    error: Use `-vdebug` to see the full traceback.
    debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/cli/tasks.py", line 66, in sync_collection
    debug:     force_delete=force_delete
    debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 228, in sync
    debug:     action(a_info, b_info, conflict_resolution)
    debug:   File "/home/untitaker/projects/vdirsyncer/vdirsyncer/sync.py", line 276, in inner
    debug:     assert isinstance(dest_etag, (bytes, text_type))

Discovered in #467

@untitaker untitaker force-pushed the no-null-etag branch from a9d2118 to 4d65cef Aug 19, 2016

@untitaker untitaker merged commit f238a58 into master Aug 19, 2016

3 checks passed

codecov/patch 100% of diff hit (target 87.24%)
Details
codecov/project Absolute coverage decreased by -4.69% but relative coverage increased by +12.75% compared to 214ec10
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@untitaker untitaker removed the in progress label Aug 19, 2016

@untitaker untitaker deleted the no-null-etag branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment