Add xandikos to CI #601
Add xandikos to CI #601
Conversation
|
|
Oh, I thought I was doing something wrong when I approached this, so it wasn't my bad. :(
I'd like to understand this a bit more (and also, forgive my slight ignorance here), but, what don't we includ |
|
IIRC MKCOL with request body was rejected by other servers. |
|
Listing calendars with vdirsyncer works fine against xandikos for me; what request 404s for you? MKCOL with a body indeed allows specifying what resource types the new collection should have. That said, Xandikos doesn't yet support setting the resource types of newly created collections. jelmer/xandikos#16. It's correct that some servers reject a MKCOL with body; servers should reject a body they don't understand per RFC4918; RFC5689 defines an XML body for MKCOL. I've filed jelmer/xandikos#21 about automatically setting the type of collections based on under what path they were created, if there was no body specified for MKCOL. |
|
I think there's a misunderstanding in how I should set up xandikos for testing, could you review this PR? |
|
@jelmer Actually we send a MKCOL with all the properties that are necessary for xandikos to infer the collection type: https://github.com/pimutils/vdirsyncer/blob/master/vdirsyncer/storage/dav.py#L266 |
|
Turns out I wasn't setting up Xandikos correctly. We're now able to create collections properly, but the tests still don't pass. I will file issues on Xandikos for that. |
|
With current vdirsyncer and current xandikos, all tests now pass for me. |
.travis.yml
Outdated
| "env": "BUILD=test DAV_SERVER=radicale REQUIREMENTS=minimal BUILD_PRS=true ", | ||
| "python": "3.3" | ||
| }, | ||
| { | ||
| "env": "BUILD=test DAV_SERVER=xandikos REQUIREMENTS=minimal BUILD_PRS=true ", | ||
| "python": "3.3" |
There was a problem hiding this comment.
Xandikos only support python 3.5 or above:
There was a problem hiding this comment.
@jelmer Would you consider supporting Python 3.3+ (i.e. I submit PRs to xandikos if Python 3.3 breaks)
|
On Sun, Mar 19, 2017 at 06:18:18AM -0700, Markus Unterwaditzer wrote:
untitaker commented on this pull request.
> "env": "BUILD=test DAV_SERVER=radicale REQUIREMENTS=minimal BUILD_PRS=true ",
"python": "3.3"
},
{
+ "env": "BUILD=test DAV_SERVER=xandikos REQUIREMENTS=minimal BUILD_PRS=true ",
+ "python": "3.3"
@jelmer Would you consider supporting Python 3.3+ (i.e. I submit PRs to xandikos if Python 3.3 breaks)
For 3.4 that would probably be okay so long as it doesn't introduce
too much extra complexity.
3.3 is trickier, since e.g. Dulwich also doesn't support 3.3 at the
moment.
|
|
Dulwich & Xandikos now support 3.3. That was way easier than I was expecting, no changes necessary. |
|
@jelmer the tests are failing for anything below 3.6. It appears there is a bug in the urllib module that makes xandikos output double slashes for |
|
One of your recent commits breaks the CI again :( |
|
Argh, fixed now. Another reason to extend the unit test coverage further... |
|
I wonder if, as a way to get around the temporarily lack of coverage, you could run vdirsyncer's test suite for Xandiko's CI. :P |
|
Thanks all! 🎉 |
Fix #597
Bugs:
calendar-home-setis missing, so blocked on allow setting calendar home set / addressbook home set paths jelmer/xandikos#17Other chores: