Initial etesync support #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
untitaker
commented
Mar 30, 2017
•
untitaker
commented
- tests leave repo in dirty state
WhyNotHugo
reviewed
Mar 30, 2017
| @@ -40,7 +40,7 @@ class Item(object): | |||
| VCARD''' | |||
|
|
|||
| def __init__(self, raw): | |||
| assert isinstance(raw, str) | |||
| assert isinstance(raw, str), type(raw) | |||
There was a problem hiding this comment.
What exactly does type(raw) do here? I don't quite understand the syntax.
There was a problem hiding this comment.
type(raw) is the error message. It's not related but should be there IMO either way.
There was a problem hiding this comment.
Oh, cool, didn't know the syntax.
|
IIRC, type(raw) will used as the AssertionError's parameter should
isinstance be Falseish
Quoting Hugo Osvaldo Barrera (2017-03-30 20:21:40)
… hobarrera commented on this pull request.
> @@ -40,7 +40,7 @@ class Item(object):
VCARD'''
def __init__(self, raw):
- assert isinstance(raw, str)
+ assert isinstance(raw, str), type(raw)
What exactly does `type(raw)` do here? I don't quite understand the syntax.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#614 (review)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.