New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial etesync support #614

Merged
merged 36 commits into from Apr 13, 2017

Conversation

Projects
None yet
3 participants
@untitaker
Member

untitaker commented Mar 30, 2017

  • tests leave repo in dirty state

@untitaker untitaker force-pushed the etesync branch from c85edcf to ee43efa Mar 30, 2017

@@ -40,7 +40,7 @@ class Item(object):
VCARD'''
def __init__(self, raw):
assert isinstance(raw, str)
assert isinstance(raw, str), type(raw)

This comment has been minimized.

@WhyNotHugo

WhyNotHugo Mar 30, 2017

Member

What exactly does type(raw) do here? I don't quite understand the syntax.

This comment has been minimized.

@untitaker

untitaker Mar 30, 2017

Member

type(raw) is the error message. It's not related but should be there IMO either way.

This comment has been minimized.

@WhyNotHugo

WhyNotHugo Mar 30, 2017

Member

Oh, cool, didn't know the syntax.

untitaker added some commits Mar 30, 2017

@geier

This comment has been minimized.

Member

geier commented Mar 30, 2017

untitaker added some commits Mar 30, 2017

wip

untitaker added some commits Apr 5, 2017

wip
wip

@untitaker untitaker merged commit 0d9ec64 into master Apr 13, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@untitaker untitaker removed the in progress label Apr 13, 2017

untitaker added a commit that referenced this pull request Apr 13, 2017

@untitaker untitaker deleted the etesync branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment