Possible problems found by static analysis of code #2

Merged
merged 3 commits into from Oct 20, 2011
Commits on Jun 23, 2011
  1. @jpopelka

    Coverity: FORWARD_NULL

    jpopelka committed Jun 23, 2011
    src/mixed.c:56: assign_zero: Assigning: "task->input.name" = 0.
    src/mixed.c:64: var_deref_op: Dereferencing null variable "task->input.name".
  2. @jpopelka

    Coverity: UNINIT

    jpopelka committed Jun 23, 2011
    src/recode.c:192: var_decl: Declaring variable "right_table" without initializer.
    src/recode.c:240: uninit_use_in_call: Using uninitialized value
                      "right_table[right]" when calling "recode_error".
    
    src/recode.c:191: var_decl: Declaring variable "left_table" without initializer.
    src/recode.c:228: uninit_use_in_call: Using uninitialized value
                      "left_table[left]" when calling "recode_error".
    src/recode.c:281: uninit_use: Using uninitialized value "left_table[search]".
  3. @jpopelka

    Coverity: RESOURCE_LEAK

    jpopelka committed Jun 23, 2011
    src/hash.c:783: var_assign: Assigning: "new_table" =  storage returned from
                    "hash_initialize(candidate, table->tuning, table->hasher,
                                     table->comparator, table->data_freer)".
    src/hash.c:816: leaked_storage: Variable "new_table" going out of scope
                                    leaks the storage it points to.
    
    src/html.c:428: var_assign: Assigning: "table" =  storage returned from
                    "hash_initialize(0U, NULL, code_hash, code_compare, NULL)".
    src/html.c:436: leaked_storage: Variable "table" going out of scope
                                    leaks the storage it points to.
    
    src/html.c:609: var_assign: Assigning: "table" =  storage returned from
                    "hash_initialize(0U, NULL, string_hash, string_compare, NULL)".
    src/html.c:617: leaked_storage: Variable "table" going out of scope
                                    leaks the storage it points to.
    
    src/request.c:758: var_assign: Assigning: "new" =  storage returned from
                                   "recode_malloc(outer, 16UL)".
    src/request.c:768: leaked_storage: Variable "new" going out of scope
                                       leaks the storage it points to.