HEAD method on email confirmation view causes exception #55

Closed
lukeman opened this Issue Jan 4, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Member

lukeman commented Jan 4, 2013

Hit this in the wild on a site. Not sure when exactly a client would send HEAD, but it at least happened once. Maybe just have a fallback to use the confirm template. User agent was, oddly, gvfs/1.12.3 which I think is Gnome's sftp/ftp/webdav/etc mounting stuff.

Also may not be worth fixing, but figured I'd report.

KeyError: 'HEAD'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "django/views/generic/base.py", line 48, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/generic/base.py", line 69, in dispatch
    return handler(request, *args, **kwargs)
  File "account/views.py", line 320, in get
    return self.render_to_response(ctx)
  File "django/views/generic/base.py", line 95, in render_to_response
    template = self.get_template_names(),
  File "account/views.py", line 315, in get_template_names
    }[self.request.method]
Owner

brosner commented Jan 4, 2013

Yeah, it would be good to limit what we accept and reject all others to avoid tossing the exception.

Owner

brosner commented Jan 14, 2014

Looks like this one was fixed in a7c7873

brosner closed this Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment